Commitd7a95f0

committed

Minor comment updates

Fix a couple of typos, and update a comment about why we set a BMS toNULL.Author: David RowleyDiscussion:http://postgr.es/m/CAKJS1f-tux=KdUz6ENJ9GHM_V2qgxysadYiOyQS9Ko9PTteVhQ@mail.gmail.com

1 parent7ba6ee8 commitd7a95f0Copy full SHA for d7a95f0

File tree

-5

lines changed

src
- backend/executor
  - execPartition.c
- include/partitioning
  - partprune.h

-5

lines changed

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1524,9 +1524,12 @@ ExecFindInitialMatchingSubPlans(PartitionPruneState *prunestate, int nsubnodes)`
`1524`	`1524`
`1525`	`1525`	`/*`
`1526`	`1526`	`* Record that partition pruning has been performed for external params.`
`1527`		`- * This partly also serves to ensure we never call this function twice`
`1528`		`- * with the same input and also so that ExecFindMatchingSubPlans is aware`
`1529`		`- * that pruning has already been performed for external Params.`
	`1527`	`+ * These are not required again afterwards, and nullifying them helps`
	`1528`	`+ * ensure nothing accidentally calls this function twice on the same`
	`1529`	`+ * PartitionPruneState.`
	`1530`	`+ *`
	`1531`	`+ * (Note we keep prunestate->allparams, because we do use that one`
	`1532`	`+ * repeatedly in ExecFindMatchingSubPlans).`
`1530`	`1533`	`*/`
`1531`	`1534`	`bms_free(prunestate->extparams);`
`1532`	`1535`	`prunestate->extparams=NULL;`
`@@ -1607,7 +1610,7 @@ ExecFindInitialMatchingSubPlans(PartitionPruneState *prunestate, int nsubnodes)`
`1607`	`1610`
`1608`	`1611`	`/*`
`1609`	`1612`	`* ExecFindMatchingSubPlans`
`1610`		`- *Determine which subplans match thethepruning steps detailed in`
	`1613`	`+ *Determine which subplans match the pruning steps detailed in`
`1611`	`1614`	`*'pprune' for the current Param values.`
`1612`	`1615`	`*`
`1613`	`1616`	`* Here we utilize both external and exec Params for pruning.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ typedef struct PartitionPruneContext`
`40`	`40`
`41`	`41`	`/*`
`42`	`42`	`* Can be set when the context is used from the executor to allow params`
`43`		`- * found matching the partition key to beevaulated.`
	`43`	`+ * found matching the partition key to beevaluated.`
`44`	`44`	`*/`
`45`	`45`	`PlanState*planstate;`
`46`	`46`

Comments

(0)