NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd77f014

committed

Improve implementation of EEOP_BOOLTEST_* opcodes.

Both Andres and I were happy with "*op->resvalue = *op->resvalue;",but Coverity isn't; and it has a point, because some compilers mightnot be smart enough to elide that. So remove it. In passing, alsoavoid doing unnecessary assignments to *op->resnull when it's alreadyknown to have the right value.

1 parente259e1f commitd77f014Copy full SHA for d77f014

File tree

1 file changed

+14

-8

lines changed

src/backend/executor
- execExprInterp.c

1 file changed

+14

-8

lines changed

`‎src/backend/executor/execExprInterp.c`

Lines changed: 14 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -958,43 +958,49 @@ ExecInterpExpr(ExprState state, ExprContext econtext, bool *isnull)`
`958`	`958`	`EEO_CASE(EEOP_BOOLTEST_IS_TRUE)`
`959`	`959`	`{`
`960`	`960`	`if (*op->resnull)`
	`961`	`+{`
`961`	`962`	`*op->resvalue=BoolGetDatum(false);`
`962`		`-else`
`963`		`-op->resvalue=op->resvalue;`
`964`		`-*op->resnull= false;`
	`963`	`+*op->resnull= false;`
	`964`	`+}`
	`965`	`+/* else, input value is the correct output as well */`
`965`	`966`
`966`	`967`	`EEO_NEXT();`
`967`	`968`	`}`
`968`	`969`
`969`	`970`	`EEO_CASE(EEOP_BOOLTEST_IS_NOT_TRUE)`
`970`	`971`	`{`
`971`	`972`	`if (*op->resnull)`
	`973`	`+{`
`972`	`974`	`*op->resvalue=BoolGetDatum(true);`
	`975`	`+*op->resnull= false;`
	`976`	`+}`
`973`	`977`	`else`
`974`	`978`	`op->resvalue=BoolGetDatum(!DatumGetBool(op->resvalue));`
`975`		`-*op->resnull= false;`
`976`	`979`
`977`	`980`	`EEO_NEXT();`
`978`	`981`	`}`
`979`	`982`
`980`	`983`	`EEO_CASE(EEOP_BOOLTEST_IS_FALSE)`
`981`	`984`	`{`
`982`	`985`	`if (*op->resnull)`
	`986`	`+{`
`983`	`987`	`*op->resvalue=BoolGetDatum(false);`
	`988`	`+*op->resnull= false;`
	`989`	`+}`
`984`	`990`	`else`
`985`	`991`	`op->resvalue=BoolGetDatum(!DatumGetBool(op->resvalue));`
`986`		`-*op->resnull= false;`
`987`	`992`
`988`	`993`	`EEO_NEXT();`
`989`	`994`	`}`
`990`	`995`
`991`	`996`	`EEO_CASE(EEOP_BOOLTEST_IS_NOT_FALSE)`
`992`	`997`	`{`
`993`	`998`	`if (*op->resnull)`
	`999`	`+{`
`994`	`1000`	`*op->resvalue=BoolGetDatum(true);`
`995`		`-else`
`996`		`-op->resvalue=op->resvalue;`
`997`		`-*op->resnull= false;`
	`1001`	`+*op->resnull= false;`
	`1002`	`+}`
	`1003`	`+/* else, input value is the correct output as well */`
`998`	`1004`
`999`	`1005`	`EEO_NEXT();`
`1000`	`1006`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd77f014

File tree

1 file changed

1 file changed

`‎src/backend/executor/execExprInterp.c`

0 commit comments