NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd76886c

committed

Dept of second thoughts: keep aliasp_item in sync with tlistitem.

Commitd5b760e wasn't quite right, on second thought: if thecaller didn't ask for column names then it would happily emitmore Vars than if the caller did ask for column names. Thisis surely not a good idea. Advance the aliasp_item whether ornot we're preparing a colnames list.

1 parentd5b760e commitd76886cCopy full SHA for d76886c

File tree

1 file changed

-1

lines changed

src/backend/parser
- parse_relation.c

1 file changed

-1

lines changed

`‎src/backend/parser/parse_relation.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2221,7 +2221,6 @@ expandRTE(RangeTblEntry *rte, int rtindex, int sublevels_up,`
`2221`	`2221`	`char*label=strVal(lfirst(aliasp_item));`
`2222`	`2222`
`2223`	`2223`	`colnames=lappend(colnames,makeString(pstrdup(label)));`
`2224`		`-aliasp_item=lnext(aliasp_item);`
`2225`	`2224`	`}`
`2226`	`2225`
`2227`	`2226`	`if (colvars)`
`@@ -2237,6 +2236,8 @@ expandRTE(RangeTblEntry *rte, int rtindex, int sublevels_up,`
`2237`	`2236`
`2238`	`2237`	`colvars=lappend(colvars,varnode);`
`2239`	`2238`	`}`
	`2239`	`+`
	`2240`	`+aliasp_item=lnext(aliasp_item);`
`2240`	`2241`	`}`
`2241`	`2242`	`}`
`2242`	`2243`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd76886c

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_relation.c`

0 commit comments