NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd73b7f9

committed

Fix memory leaks in failure paths in buildACLCommands and parseAclItem.

This is currently only cosmetic, since all the call sites just curl upand die in event of a failure return. It might be important for somefuture use-case, though, and in any case it quiets warnings from theclang static analyzer (as reported by Anna Zaks).Josh Kupershmidt

1 parent8fcbfea commitd73b7f9Copy full SHA for d73b7f9

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- dumputils.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/dumputils.c`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,10 @@ buildACLCommands(const char name, const char subname,`
`600`	`600`	`{`
`601`	`601`	`if (!parseAclItem(aclitems[i],type,name,subname,remoteVersion,`
`602`	`602`	`grantee,grantor,privs,privswgo))`
	`603`	`+{`
	`604`	`+free(aclitems);`
`603`	`605`	`return false;`
	`606`	`+}`
`604`	`607`
`605`	`608`	`if (grantor->len==0&&owner)`
`606`	`609`	`printfPQExpBuffer(grantor,"%s",owner);`
`@@ -789,7 +792,10 @@ parseAclItem(const char item, const char type,`
`789`	`792`	`/* user or group name is string up to = */`
`790`	`793`	`eqpos=copyAclUserName(grantee,buf);`
`791`	`794`	`if (*eqpos!='=')`
	`795`	`+{`
	`796`	`+free(buf);`
`792`	`797`	`return false;`
	`798`	`+}`
`793`	`799`
`794`	`800`	`/* grantor may be listed after / */`
`795`	`801`	`slpos=strchr(eqpos+1,'/');`
`@@ -798,7 +804,10 @@ parseAclItem(const char item, const char type,`
`798`	`804`	`*slpos++='\0';`
`799`	`805`	`slpos=copyAclUserName(grantor,slpos);`
`800`	`806`	`if (*slpos!='\0')`
	`807`	`+{`
	`808`	`+free(buf);`
`801`	`809`	`return false;`
	`810`	`+}`
`802`	`811`	`}`
`803`	`812`	`else`
`804`	`813`	`resetPQExpBuffer(grantor);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd73b7f9

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/dumputils.c`

0 commit comments