forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitd6b059e
committed
Document intentional violations of header inclusion policy.
Although there are good reasons for our policy of including postgres.has the first #include in every .c file, never from .h files, there aretwo places where it seems expedient to violate the policy because thealternative is to modify externally-supplied .c files. (In the caseof the regexp library, the idea that it's externally-supplied is kindof at odds with reality, but I haven't entirely given up hope that itwill become a standalone project some day.) Add some comments to makeit explicit that this is a policy violation and provide the reasoning.In passing, move #include "miscadmin.h" out of regcomp.c and intoregcustom.h, which is where it should be if we're taking this reasoningseriously at all.Discussion:https://postgr.es/m/CAEepm=2zCoeq3QxVwhS5DFeUh=yU6z81pbWMgfOB8OzyiBwxzw@mail.gmail.comDiscussion:https://postgr.es/m/11634.1488932128@sss.pgh.pa.us1 parent2f899e7 commitd6b059e
File tree
3 files changed
+14
-2
lines changed- src
- backend/regex
- include
- regex
- snowball
3 files changed
+14
-2
lines changedLines changed: 0 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
34 | 34 |
| |
35 | 35 |
| |
36 | 36 |
| |
37 |
| - | |
38 |
| - | |
39 | 37 |
| |
40 | 38 |
| |
41 | 39 |
| |
|
Lines changed: 9 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
29 | 29 |
| |
30 | 30 |
| |
31 | 31 |
| |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
32 | 39 |
| |
33 | 40 |
| |
34 | 41 |
| |
| |||
47 | 54 |
| |
48 | 55 |
| |
49 | 56 |
| |
| 57 | + | |
| 58 | + | |
50 | 59 |
| |
51 | 60 |
| |
52 | 61 |
| |
|
Lines changed: 5 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
22 | 22 |
| |
23 | 23 |
| |
24 | 24 |
| |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 |
| |
26 | 31 |
| |
27 | 32 |
| |
|
0 commit comments
Comments
(0)