NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd65b665

committed

Guard against zero vardata.rel->tuples in estimate_hash_bucketsize().

If the referenced rel was proven empty, we'd compute 0/0 here, whichresults in the function returning NaN. That's a bit more seriousthan the other zero-divide case. Still, it only seems to be possiblein HEAD, so no back-patch.Per report from Piotr Stefaniak. I looked through the rest of selfuncs.cand found no other likely trouble spots.

1 parentfa09f89 commitd65b665Copy full SHA for d65b665

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- selfuncs.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/selfuncs.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3540,7 +3540,7 @@ estimate_hash_bucketsize(PlannerInfo root, Node hashkey, double nbuckets)`
`3540`	`3540`	`* XXX Possibly better way, but much more expensive: multiply by`
`3541`	`3541`	`* selectivity of rel's restriction clauses that mention the target Var.`
`3542`	`3542`	`*/`
`3543`		`-if (vardata.rel)`
	`3543`	`+if (vardata.rel&&vardata.rel->tuples>0)`
`3544`	`3544`	`{`
`3545`	`3545`	`ndistinct *=vardata.rel->rows /vardata.rel->tuples;`
`3546`	`3546`	`ndistinct=clamp_row_est(ndistinct);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd65b665

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/selfuncs.c`

0 commit comments