NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd64e646

Amit Kapila

committed

Reload configuration more frequently in apply worker.

The apply worker was not reloading the configuration while processingmessages if there is a continuous flow of messages from upstream. It wasalso not reloading the configuration if there is a change in theconfiguration after it has waited for the message and before receiving thenew replication message. This can lead to failure in tests because weexpect that after reload, the behavior of apply worker to respect thechanged GUCs.We found this while analyzing a rare buildfarm failure.Author: Hou ZhijieReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/OS0PR01MB5716AF9079CC0755CD015322947E9@OS0PR01MB5716.jpnprd01.prod.outlook.com

1 parent95f0340 commitd64e646Copy full SHA for d64e646

File tree

1 file changed

-0

lines changed

src/backend/replication/logical
- worker.c

1 file changed

-0

lines changed

`‎src/backend/replication/logical/worker.c`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3562,6 +3562,12 @@ LogicalRepApplyLoop(XLogRecPtr last_received)`
`3562`	`3562`	`intc;`
`3563`	`3563`	`StringInfoDatas;`
`3564`	`3564`
	`3565`	`+if (ConfigReloadPending)`
	`3566`	`+{`
	`3567`	`+ConfigReloadPending= false;`
	`3568`	`+ProcessConfigFile(PGC_SIGHUP);`
	`3569`	`+}`
	`3570`	`+`
`3565`	`3571`	`/* Reset timeout. */`
`3566`	`3572`	`last_recv_timestamp=GetCurrentTimestamp();`
`3567`	`3573`	`ping_sent= false;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd64e646

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/worker.c`

0 commit comments