NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd5a7bd5

committed

Fix variable reference in comment

This used to say "nsubxcnt isn't decreased when subtransactionsabort", but there's no variable called nsubxcnt. Commit8548ddcchanged it to "subxcnt", among other typo fixes, but that was wrongtoo: the comment actually talks about txn->nsubtxns. That's the fieldthat's incremented but never decremented and is used for theallocation earlier in the function.

1 parent94bb6c4 commitd5a7bd5Copy full SHA for d5a7bd5

File tree

1 file changed

-3

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-3

lines changed

`‎src/backend/replication/logical/reorderbuffer.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1861,9 +1861,9 @@ ReorderBufferCopySnap(ReorderBuffer *rb, Snapshot orig_snap,`
`1861`	`1861`	`snap->subxip[i++]=txn->xid;`
`1862`	`1862`
`1863`	`1863`	`/*`
`1864`		`- *subxcnt isn't decreased when subtransactions abort, so count manually.`
`1865`		`- * Since it's an upper boundary it is safe to use it for the allocation`
`1866`		`- * above.`
	`1864`	`+ *txn->nsubtxns isn't decreased when subtransactions abort, so count`
	`1865`	`+ *manually.Since it's an upper boundary it is safe to use it for the`
	`1866`	`+ *allocationabove.`
`1867`	`1867`	`*/`
`1868`	`1868`	`snap->subxcnt=1;`
`1869`	`1869`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd5a7bd5

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c`

0 commit comments