NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd59ff4a

committed

Fix another instance of unsafe coding for shm_toc_lookup failure.

One or another author of commit5bcf389 seems to have thought thatcomputing an offset from a NULL pointer would yield another NULL pointer.There may possibly be architectures where that works, but common machinesdon't work like that. Per a quick code review of places callingshm_toc_lookup and not using noError = false.

1 parent957ff08 commitd59ff4aCopy full SHA for d59ff4a

File tree

1 file changed

-1

lines changed

src/backend/executor
- nodeHash.c

1 file changed

-1

lines changed

`‎src/backend/executor/nodeHash.c‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2582,9 +2582,13 @@ ExecHashInitializeWorker(HashState node, ParallelWorkerContext pwcxt)`
`2582`	`2582`	`{`
`2583`	`2583`	`SharedHashInfo*shared_info;`
`2584`	`2584`
	`2585`	`+/* might not be there ... */`
`2585`	`2586`	`shared_info= (SharedHashInfo*)`
`2586`	`2587`	`shm_toc_lookup(pwcxt->toc,node->ps.plan->plan_node_id, true);`
`2587`		`-node->hinstrument=&shared_info->hinstrument[ParallelWorkerNumber];`
	`2588`	`+if (shared_info)`
	`2589`	`+node->hinstrument=&shared_info->hinstrument[ParallelWorkerNumber];`
	`2590`	`+else`
	`2591`	`+node->hinstrument=NULL;`
`2588`	`2592`	`}`
`2589`	`2593`
`2590`	`2594`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd59ff4a

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeHash.c‎`

0 commit comments