NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd547f7c

Amit Kapila

committed

Re-order disable_on_error in tab-complete.

By convention, the tab-complete subscription parameters are listed in theCOMPLETE_WITH lists in alphabetical order, but when the "disable_on_error"parameter was introduced this was not done.This patch just tidies that up.Reported-by: Peter SmithAuthor: Peter SmithReviewed-by: Euler Taveira, Takamichi OsumiBackpatch-through: 15, where it was introducedDiscussion:https://postgr.es/m/CAHut+PucvKZgg_eJzUW--iL6DXHg1Jwj6F09tQziE3kUF67uLg@mail.gmail.com

1 parent1409ead commitd547f7cCopy full SHA for d547f7c

File tree

1 file changed

-3

lines changed

src/bin/psql
- tab-complete.c

1 file changed

-3

lines changed

`‎src/bin/psql/tab-complete.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1873,7 +1873,7 @@ psql_completion(const char *text, int start, int end)`
`1873`	`1873`	`COMPLETE_WITH("(","PUBLICATION");`
`1874`	`1874`	`/* ALTER SUBSCRIPTION <name> SET ( */`
`1875`	`1875`	`elseif (HeadMatches("ALTER","SUBSCRIPTION",MatchAny)&&TailMatches("SET","("))`
`1876`		`-COMPLETE_WITH("binary","slot_name","streaming","synchronous_commit","disable_on_error");`
	`1876`	`+COMPLETE_WITH("binary","disable_on_error","slot_name","streaming","synchronous_commit");`
`1877`	`1877`	`/* ALTER SUBSCRIPTION <name> SKIP ( */`
`1878`	`1878`	`elseif (HeadMatches("ALTER","SUBSCRIPTION",MatchAny)&&TailMatches("SKIP","("))`
`1879`	`1879`	`COMPLETE_WITH("lsn");`
`@@ -3152,8 +3152,8 @@ psql_completion(const char *text, int start, int end)`
`3152`	`3152`	`/* Complete "CREATE SUBSCRIPTION <name> ... WITH ( <opt>" */`
`3153`	`3153`	`elseif (HeadMatches("CREATE","SUBSCRIPTION")&&TailMatches("WITH","("))`
`3154`	`3154`	`COMPLETE_WITH("binary","connect","copy_data","create_slot",`
`3155`		`-"enabled","slot_name","streaming",`
`3156`		`-"synchronous_commit","two_phase","disable_on_error");`
	`3155`	`+"disable_on_error","enabled","slot_name","streaming",`
	`3156`	`+"synchronous_commit","two_phase");`
`3157`	`3157`
`3158`	`3158`	`/* CREATE TRIGGER --- is allowed inside CREATE SCHEMA, so use TailMatches */`
`3159`	`3159`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd547f7c

File tree

1 file changed

1 file changed

`‎src/bin/psql/tab-complete.c`

0 commit comments