Commitd536d03

committed

Fix overly generic name in with.sql test.

Avoid the name "test". In the 10 branch, this could clash withalter_table.sql, as seen in the build farm. That other instance wasalready renamed in later branches by commit2cf8c7a, but it's good tofuture-proof the name here too.Back-patch to 10.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/CA%2BhUKGJf4RAXUyAYVUcQawcptX%3DnhEco3SYpuPK5cCbA-F1eLA%40mail.gmail.com

1 parent9ac9878 commitd536d03Copy full SHA for d536d03

File tree

+13

-13

lines changed

+13

-13

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -2333,19 +2333,19 @@ with ordinality as (select 1 as x) select * from ordinality;`
`2333`	`2333`	`(1 row)`
`2334`	`2334`
`2335`	`2335`	`-- check sane response to attempt to modify CTE relation`
`2336`		`-WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`2337`		`-ERROR: relation "test" does not exist`
`2338`		`-LINE 1: WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`2339`		`- ^`
	`2336`	`+WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (1);`
	`2337`	`+ERROR: relation "with_test" does not exist`
	`2338`	`+LINE 1: WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (...`
	`2339`	`+^`
`2340`	`2340`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`2341`	`2341`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`2342`	`2342`	`-- statements)`
`2343`		`-create temp tabletest (i int);`
`2344`		`-withtest as (select 42) insert intotest select * fromtest;`
`2345`		`-select * fromtest;`
	`2343`	`+create temp tablewith_test (i int);`
	`2344`	`+withwith_test as (select 42) insert intowith_test select * fromwith_test;`
	`2345`	`+select * fromwith_test;`
`2346`	`2346`	`i`
`2347`	`2347`	`----`
`2348`	`2348`	`42`
`2349`	`2349`	`(1 row)`
`2350`	`2350`
`2351`		`-drop tabletest;`
	`2351`	`+drop tablewith_test;`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1076,12 +1076,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word`
`1076`	`1076`	`with ordinalityas (select1as x)select*from ordinality;`
`1077`	`1077`
`1078`	`1078`	`-- check sane response to attempt to modify CTE relation`
`1079`		`-WITHtestAS (SELECT42)INSERT INTOtestVALUES (1);`
	`1079`	`+WITHwith_testAS (SELECT42)INSERT INTOwith_testVALUES (1);`
`1080`	`1080`
`1081`	`1081`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`1082`	`1082`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`1083`	`1083`	`-- statements)`
`1084`		`-create temp tabletest (iint);`
`1085`		`-withtestas (select42)insert intotestselect*fromtest;`
`1086`		`-select*fromtest;`
`1087`		`-droptabletest;`
	`1084`	`+create temp tablewith_test (iint);`
	`1085`	`+withwith_testas (select42)insert intowith_testselect*fromwith_test;`
	`1086`	`+select*fromwith_test;`
	`1087`	`+droptablewith_test;`

Comments

(0)