NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd515365

committed

Don't bother copying empty support arrays in a zero-column MergeJoin.

The case could not arise when this code was originally written, but it cannow (since we made zero-column MergeJoins work for the benefit of FULL JOINON TRUE). I don't think there is any actual bug here, but we might as welltreat it consistently with other uses of COPY_POINTER_FIELD(). Per commentfrom Ashutosh Bapat.

1 parente969f9a commitd515365Copy full SHA for d515365

File tree

1 file changed

-4

lines changed

src/backend/nodes
- copyfuncs.c

1 file changed

-4

lines changed

`‎src/backend/nodes/copyfuncs.c‎`

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -672,10 +672,13 @@ _copyMergeJoin(const MergeJoin *from)`
`672`	`672`	`*/`
`673`	`673`	`COPY_NODE_FIELD(mergeclauses);`
`674`	`674`	`numCols=list_length(from->mergeclauses);`
`675`		`-COPY_POINTER_FIELD(mergeFamilies,numCols*sizeof(Oid));`
`676`		`-COPY_POINTER_FIELD(mergeCollations,numCols*sizeof(Oid));`
`677`		`-COPY_POINTER_FIELD(mergeStrategies,numCols*sizeof(int));`
`678`		`-COPY_POINTER_FIELD(mergeNullsFirst,numCols*sizeof(bool));`
	`675`	`+if (numCols>0)`
	`676`	`+{`
	`677`	`+COPY_POINTER_FIELD(mergeFamilies,numCols*sizeof(Oid));`
	`678`	`+COPY_POINTER_FIELD(mergeCollations,numCols*sizeof(Oid));`
	`679`	`+COPY_POINTER_FIELD(mergeStrategies,numCols*sizeof(int));`
	`680`	`+COPY_POINTER_FIELD(mergeNullsFirst,numCols*sizeof(bool));`
	`681`	`+}`
`679`	`682`
`680`	`683`	`returnnewnode;`
`681`	`684`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd515365

File tree

1 file changed

1 file changed

`‎src/backend/nodes/copyfuncs.c‎`

0 commit comments