NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd50e3b1

committed

Fix assertion in collation version lookup.

Commit257836a included an assertion that a version lookup routine isnot trying to look up "C" or "POSIX", but that case is reachable withthe user-facing SQL function pg_collation_actual_version(). Remove theassertion.

1 parent8cff66d commitd50e3b1Copy full SHA for d50e3b1

File tree

1 file changed

-4

lines changed

src/backend/utils/adt
- pg_locale.c

1 file changed

-4

lines changed

`‎src/backend/utils/adt/pg_locale.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1731,15 +1731,14 @@ get_collation_actual_version(char collprovider, const char *collcollate)`
`1731`	`1731`
`1732`	`1732`	`/*`
`1733`	`1733`	`* Get provider-specific collation version string for a given collation OID.`
`1734`		`- * Return NULL if the provider doesn't support versions.`
	`1734`	`+ * Return NULL if the provider doesn't support versions, or the collation is`
	`1735`	`+ * unversioned (for example "C").`
`1735`	`1736`	`*/`
`1736`	`1737`	`char*`
`1737`	`1738`	`get_collation_version_for_oid(Oidoid)`
`1738`	`1739`	`{`
`1739`	`1740`	`HeapTupletp;`
`1740`		`-char*version=NULL;`
`1741`		`-`
`1742`		`-Assert(oid!=C_COLLATION_OID&&oid!=POSIX_COLLATION_OID);`
	`1741`	`+char*version;`
`1743`	`1742`
`1744`	`1743`	`if (oid==DEFAULT_COLLATION_OID)`
`1745`	`1744`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd50e3b1

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/pg_locale.c`

0 commit comments