NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd4a9004

committed

Cosmetic cleanups in initdb.c.

Commitbcbd940 didn't bother to fix up a comment it had falsified.Also, const-ify choose_dsm_implementation(), since what it's returningis always a constant string; pickier compilers would warn about this.

1 parentf841ceb commitd4a9004Copy full SHA for d4a9004

File tree

1 file changed

-6

lines changed

src/bin/initdb
- initdb.c

1 file changed

-6

lines changed

`‎src/bin/initdb/initdb.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ static char *pgdata_native;`
`173`	`173`	`/* defaults */`
`174`	`174`	`staticintn_connections=10;`
`175`	`175`	`staticintn_buffers=50;`
`176`		`-staticchar*dynamic_shared_memory_type=NULL;`
	`176`	`+staticconstchar*dynamic_shared_memory_type=NULL;`
`177`	`177`
`178`	`178`	`/*`
`179`	`179`	`* Warning messages for authentication methods`
`@@ -916,7 +916,7 @@ set_null_conf(void)`
`916`	`916`	`* the postmaster either, and configure the cluster for System V shared`
`917`	`917`	`* memory instead.`
`918`	`918`	`*/`
`919`		`-staticchar*`
	`919`	`+staticconstchar*`
`920`	`920`	`choose_dsm_implementation(void)`
`921`	`921`	`{`
`922`	`922`	`#ifdefHAVE_SHM_OPEN`
`@@ -952,9 +952,7 @@ choose_dsm_implementation(void)`
`952`	`952`	`/*`
`953`	`953`	`* Determine platform-specific config settings`
`954`	`954`	`*`
`955`		`- * Use reasonable values if kernel will let us, else scale back. Probe`
`956`		`- * for max_connections first since it is subject to more constraints than`
`957`		`- * shared_buffers.`
	`955`	`+ * Use reasonable values if kernel will let us, else scale back.`
`958`	`956`	`*/`
`959`	`957`	`staticvoid`
`960`	`958`	`test_config_settings(void)`
`@@ -983,7 +981,6 @@ test_config_settings(void)`
`983`	`981`	`test_buffs,`
`984`	`982`	`ok_buffers=0;`
`985`	`983`
`986`		`-`
`987`	`984`	`/*`
`988`	`985`	`* Need to determine working DSM implementation first so that subsequent`
`989`	`986`	`* tests don't fail because DSM setting doesn't work.`
`@@ -993,6 +990,10 @@ test_config_settings(void)`
`993`	`990`	`dynamic_shared_memory_type=choose_dsm_implementation();`
`994`	`991`	`printf("%s\n",dynamic_shared_memory_type);`
`995`	`992`
	`993`	`+/*`
	`994`	`+ * Probe for max_connections before shared_buffers, since it is subject to`
	`995`	`+ * more constraints than shared_buffers.`
	`996`	`+ */`
`996`	`997`	`printf(_("selecting default max_connections ... "));`
`997`	`998`	`fflush(stdout);`
`998`	`999`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd4a9004

File tree

1 file changed

1 file changed

`‎src/bin/initdb/initdb.c`

0 commit comments