NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd429ebe

committed

Add a comment to AdjustIntervalForTypmod to reduce chance of future bugs.

It's not entirely evident how the logic here relates to theinterval_transform function, so let's clue people in that they need tocheck that if the rules change.

1 parent6656588 commitd429ebeCopy full SHA for d429ebe

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/timestamp.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1069,7 +1069,8 @@ AdjustIntervalForTypmod(Interval *interval, int32 typmod)`
`1069`	`1069`	`* nonzero "month" field. However that seems a bit pointless when we`
`1070`	`1070`	`* can't do it consistently. (We cannot enforce a range limit on the`
`1071`	`1071`	`* highest expected field, since we do not have any equivalent of`
`1072`		`- * SQL's <interval leading field precision>.)`
	`1072`	`+ * SQL's <interval leading field precision>.) If we ever decide to`
	`1073`	`+ * revisit this, interval_transform will likely requite adjusting.`
`1073`	`1074`	`*`
`1074`	`1075`	`* Note: before PG 8.4 we interpreted a limited set of fields as`
`1075`	`1076`	`* actually causing a "modulo" operation on a given value, potentially`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd429ebe

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c`

0 commit comments