NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd3e5728

committed

In log_newpage_range(), heed forkNum and page_std arguments.

The function assumed forkNum=MAIN_FORKNUM and page_std=true, ignoringthe actual arguments. Existing callers passed exactly those values, sothere's no live bug. Back-patch to v12, where the function firstappeared, because another fix needs this.Discussion:https://postgr.es/m/20191118045434.GA1173436@rfd.leadboat.com

1 parente629a01 commitd3e5728Copy full SHA for d3e5728

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xloginsert.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xloginsert.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1043,8 +1043,13 @@ log_newpage_range(Relation rel, ForkNumber forkNum,`
`1043`	`1043`	`BlockNumberstartblk,BlockNumberendblk,`
`1044`	`1044`	`boolpage_std)`
`1045`	`1045`	`{`
	`1046`	`+intflags;`
`1046`	`1047`	`BlockNumberblkno;`
`1047`	`1048`
	`1049`	`+flags=REGBUF_FORCE_IMAGE;`
	`1050`	`+if (page_std)`
	`1051`	`+flags \|=REGBUF_STANDARD;`
	`1052`	`+`
`1048`	`1053`	`/*`
`1049`	`1054`	`* Iterate over all the pages in the range. They are collected into`
`1050`	`1055`	`* batches of XLR_MAX_BLOCK_ID pages, and a single WAL-record is written`
`@@ -1066,7 +1071,8 @@ log_newpage_range(Relation rel, ForkNumber forkNum,`
`1066`	`1071`	`nbufs=0;`
`1067`	`1072`	`while (nbufs<XLR_MAX_BLOCK_ID&&blkno<endblk)`
`1068`	`1073`	`{`
`1069`		`-Bufferbuf=ReadBuffer(rel,blkno);`
	`1074`	`+Bufferbuf=ReadBufferExtended(rel,forkNum,blkno,`
	`1075`	`+RBM_NORMAL,NULL);`
`1070`	`1076`
`1071`	`1077`	`LockBuffer(buf,BUFFER_LOCK_EXCLUSIVE);`
`1072`	`1078`
`@@ -1088,7 +1094,7 @@ log_newpage_range(Relation rel, ForkNumber forkNum,`
`1088`	`1094`	`START_CRIT_SECTION();`
`1089`	`1095`	`for (i=0;i<nbufs;i++)`
`1090`	`1096`	`{`
`1091`		`-XLogRegisterBuffer(i,bufpack[i],REGBUF_FORCE_IMAGE \|REGBUF_STANDARD);`
	`1097`	`+XLogRegisterBuffer(i,bufpack[i],flags);`
`1092`	`1098`	`MarkBufferDirty(bufpack[i]);`
`1093`	`1099`	`}`
`1094`	`1100`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd3e5728

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xloginsert.c`

0 commit comments