Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd2a7462

Browse files
committed
regress: fix test instability
Having additional triggers in a test table made the ORDER BY clauses inold queries underspecified. Add another column there for stability.Per sporadic buildfarm pink.
1 parentab85566 commitd2a7462

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

‎src/test/regress/expected/triggers.out

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2659,7 +2659,7 @@ create trigger tg_stmt after insert on parent
26592659
for statement execute procedure trig_nothing();
26602660
select tgrelid::regclass, tgname, tgenabled from pg_trigger
26612661
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2662-
order by tgrelid::regclass::text;
2662+
order by tgrelid::regclass::text, tgname;
26632663
tgrelid | tgname | tgenabled
26642664
---------+---------+-----------
26652665
child1 | tg | O
@@ -2671,7 +2671,7 @@ alter table only parent enable always trigger tg;-- no recursion because ONLY
26712671
alter table parent enable always trigger tg_stmt;-- no recursion because statement trigger
26722672
select tgrelid::regclass, tgname, tgenabled from pg_trigger
26732673
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2674-
order by tgrelid::regclass::text;
2674+
order by tgrelid::regclass::text, tgname;
26752675
tgrelid | tgname | tgenabled
26762676
---------+---------+-----------
26772677
child1 | tg | O
@@ -2684,7 +2684,7 @@ select tgrelid::regclass, tgname, tgenabled from pg_trigger
26842684
alter table parent enable always trigger tg;
26852685
select tgrelid::regclass, tgname, tgenabled from pg_trigger
26862686
where tgrelid in ('parent'::regclass, 'child1'::regclass)
2687-
order by tgrelid::regclass::text;
2687+
order by tgrelid::regclass::text, tgname;
26882688
tgrelid | tgname | tgenabled
26892689
---------+---------+-----------
26902690
child1 | tg | A

‎src/test/regress/sql/triggers.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,18 +1836,18 @@ create trigger tg_stmt after insert on parent
18361836
for statement execute procedure trig_nothing();
18371837
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18381838
where tgrelidin ('parent'::regclass,'child1'::regclass)
1839-
order by tgrelid::regclass::text;
1839+
order by tgrelid::regclass::text, tgname;
18401840
altertable only parent enable always trigger tg;-- no recursion because ONLY
18411841
altertable parent enable always trigger tg_stmt;-- no recursion because statement trigger
18421842
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18431843
where tgrelidin ('parent'::regclass,'child1'::regclass)
1844-
order by tgrelid::regclass::text;
1844+
order by tgrelid::regclass::text, tgname;
18451845
-- The following is a no-op for the parent trigger but not so
18461846
-- for the child trigger, so recursion should be applied.
18471847
altertable parent enable always trigger tg;
18481848
select tgrelid::regclass, tgname, tgenabledfrom pg_trigger
18491849
where tgrelidin ('parent'::regclass,'child1'::regclass)
1850-
order by tgrelid::regclass::text;
1850+
order by tgrelid::regclass::text, tgname;
18511851
droptable parent, child1;
18521852

18531853
-- Verify that firing state propagates correctly on creation, too

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp