NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd24dac9

committed

Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

In commitff9f111 I mixed up inconsistent definitions of the LSN ofthe first record in a page, when the previous record ends exactly at thepage boundary. The correct LSN is adjusted to skip the WAL page header;I failed to use that when setting XLogReaderState->overwrittenRecPtr,so at WAL replay time VerifyOverwriteContrecord would refuse to letreplay continue past that record.Backpatch to 10. 9.6 also contains this bug, but it's no longer beingmaintained.Discussion:https://postgr.es/m/45597.1637694259@sss.pgh.pa.us

1 parent371087d commitd24dac9Copy full SHA for d24dac9

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xlogreader.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xlogreader.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ XLogReadRecord(XLogReaderState state, char *errormsg)`
`464`	`464`	`*/`
`465`	`465`	`if (pageHeader->xlp_info&XLP_FIRST_IS_OVERWRITE_CONTRECORD)`
`466`	`466`	`{`
`467`		`-state->overwrittenRecPtr=state->currRecPtr;`
	`467`	`+state->overwrittenRecPtr=RecPtr;`
`468`	`468`	`ResetDecoder(state);`
`469`	`469`	`RecPtr=targetPagePtr;`
`470`	`470`	`gotorestart;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd24dac9

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlogreader.c`

0 commit comments