Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitd24d669

Browse files
committed
Fix unportable shell-script syntax in pg_upgrade's test.sh.
I discovered the hard way that on some old shells, the locution FOO="" unset FOOdoes not behave the same as FOO=""; unset FOOand in fact leaves FOO set to an empty string. test.sh was inconsistentlyspelling it different ways on adjacent lines.This got broken relatively recently, in commitc737a2e, so the lack offield reports to date doesn't represent a lot of evidence that the problemis rare.
1 parent0bdeb1d commitd24d669

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎contrib/pg_upgrade/test.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ rm -rf "$BASE_PGDATA" "$PGDATA"
7676
PGDATABASE="";unset PGDATABASE
7777
PGUSER="";unset PGUSER
7878
PGSERVICE="";unset PGSERVICE
79-
PGSSLMODE=""unset PGSSLMODE
79+
PGSSLMODE="";unset PGSSLMODE
8080
PGREQUIRESSL="";unset PGREQUIRESSL
8181
PGCONNECT_TIMEOUT="";unset PGCONNECT_TIMEOUT
82-
PGHOST=""unset PGHOST
82+
PGHOST="";unset PGHOST
8383
PGHOSTADDR="";unset PGHOSTADDR
8484

8585
logdir=$PWD/log

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp