NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd234602

committed

Remove overzeleous assertions in pg_atomic_flag code.

The atomics code asserts proper alignment in various places. That'smainly because the alignment of 64bit integers is not sufficient foratomic operations on all platforms. Some ABIs only have four bytealignment, but don't have atomic behavior when crossing pageboundaries.The flags code isn't affected by that however, as the type alignmentalways is sufficient for atomic operations. Nevertheless the codeasserted alignment requirements. Before8c3debb it was only broken onhppa, after it probably affect further platforms.Thus remove the assertions for pg_atomic_flag operators.Per buildfarm animal pademelon.Discussion:https://postgr.es/m/7223.1523124425@sss.pgh.pa.usBackpatch: 9.5-

1 parent2b74022 commitd234602Copy full SHA for d234602

File tree

1 file changed

-8

lines changed

src/include/port
- atomics.h

1 file changed

-8

lines changed

`‎src/include/port/atomics.h`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,6 @@`
`174`	`174`	`staticinlinevoid`
`175`	`175`	`pg_atomic_init_flag(volatilepg_atomic_flag*ptr)`
`176`	`176`	`{`
`177`		`-AssertPointerAlignment(ptr,sizeof(*ptr));`
`178`		`-`
`179`	`177`	`pg_atomic_init_flag_impl(ptr);`
`180`	`178`	`}`
`181`	`179`
`@@ -189,8 +187,6 @@ pg_atomic_init_flag(volatile pg_atomic_flag *ptr)`
`189`	`187`	`staticinlinebool`
`190`	`188`	`pg_atomic_test_set_flag(volatilepg_atomic_flag*ptr)`
`191`	`189`	`{`
`192`		`-AssertPointerAlignment(ptr,sizeof(*ptr));`
`193`		`-`
`194`	`190`	`returnpg_atomic_test_set_flag_impl(ptr);`
`195`	`191`	`}`
`196`	`192`
`@@ -204,8 +200,6 @@ pg_atomic_test_set_flag(volatile pg_atomic_flag *ptr)`
`204`	`200`	`staticinlinebool`
`205`	`201`	`pg_atomic_unlocked_test_flag(volatilepg_atomic_flag*ptr)`
`206`	`202`	`{`
`207`		`-AssertPointerAlignment(ptr,sizeof(*ptr));`
`208`		`-`
`209`	`203`	`returnpg_atomic_unlocked_test_flag_impl(ptr);`
`210`	`204`	`}`
`211`	`205`
`@@ -217,8 +211,6 @@ pg_atomic_unlocked_test_flag(volatile pg_atomic_flag *ptr)`
`217`	`211`	`staticinlinevoid`
`218`	`212`	`pg_atomic_clear_flag(volatilepg_atomic_flag*ptr)`
`219`	`213`	`{`
`220`		`-AssertPointerAlignment(ptr,sizeof(*ptr));`
`221`		`-`
`222`	`214`	`pg_atomic_clear_flag_impl(ptr);`
`223`	`215`	`}`
`224`	`216`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd234602

File tree

1 file changed

1 file changed

`‎src/include/port/atomics.h`

0 commit comments