NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd1fcc62

committed

Fix incorrect buffer-length argument to uloc_getDisplayName().

The maxResultSize argument of uloc_getDisplayName is the number ofUChars in the output buffer, not the number of bytes. In principlethis could result in a stack smash, although at least in my Fedora 25install there are no ICU locales with display names long enough tooverrun the buffer. But it's easily proven to be wrong by reducingthe length of displayname to around 20, whereupon a stack smashdoes happen.(This is a rather scary bug, because the same mistake could easilyhave been made in other places; but in a quick code search lookingat uses of UChar I could not find any other instances.)

1 parent08859bb commitd1fcc62Copy full SHA for d1fcc62

File tree

1 file changed

-1

lines changed

src/backend/commands
- collationcmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/collationcmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ get_icu_locale_comment(const char *localename)`
`443`	`443`
`444`	`444`	`status=U_ZERO_ERROR;`
`445`	`445`	`len_uchar=uloc_getDisplayName(localename,"en",`
`446`		`-&displayname[0],sizeof(displayname),`
	`446`	`+displayname,lengthof(displayname),`
`447`	`447`	`&status);`
`448`	`448`	`if (U_FAILURE(status))`
`449`	`449`	`ereport(ERROR,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1fcc62

File tree

1 file changed

1 file changed

`‎src/backend/commands/collationcmds.c`

0 commit comments