Commitd1f0aa7

committed

Fix pg_visibility regression failure with CLOBBER_CACHE_ALWAYS

Commit8e03eb9 reverted a bit too much code, reintroducing one of theissues fixed by39b66a9 - a page might have been left partially emptyafter relcache invalidation.Reported-By: Tom LaneAuthor: Masahiko SawadaDiscussion:https://postgr.es/m/822752.1623032114@sss.pgh.pa.usDiscussion:https://postgr.es/m/CAD21AoA%3D%3Df2VSw3c-Cp_y%3DWLKHMKc1D6s7g3YWsCOvgaYPpJcg%40mail.gmail.com

1 parentbfeede9 commitd1f0aa7Copy full SHA for d1f0aa7

File tree

+11

-11

lines changed

+11

-11

lines changed

Lines changed: 11 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -407,19 +407,19 @@ RelationGetBufferForTuple(Relation relation, Size len,`
`407`	`407`	`* target.`
`408`	`408`	`*/`
`409`	`409`	`targetBlock=GetPageWithFreeSpace(relation,targetFreeSpace);`
	`410`	`+}`
`410`	`411`
`411`		`-/*`
`412`		`- * If the FSM knows nothing of the rel, try the last page before we`
`413`		`- * give up and extend. This avoids one-tuple-per-page syndrome during`
`414`		`- * bootstrapping or in a recently-started system.`
`415`		`- */`
`416`		`-if (targetBlock==InvalidBlockNumber)`
`417`		`-{`
`418`		`-BlockNumbernblocks=RelationGetNumberOfBlocks(relation);`
	`412`	`+/*`
	`413`	`+ * If the FSM knows nothing of the rel, try the last page before we`
	`414`	`+ * give up and extend. This avoids one-tuple-per-page syndrome during`
	`415`	`+ * bootstrapping or in a recently-started system.`
	`416`	`+ */`
	`417`	`+if (targetBlock==InvalidBlockNumber)`
	`418`	`+{`
	`419`	`+BlockNumbernblocks=RelationGetNumberOfBlocks(relation);`
`419`	`420`
`420`		`-if (nblocks>0)`
`421`		`-targetBlock=nblocks-1;`
`422`		`-}`
	`421`	`+if (nblocks>0)`
	`422`	`+targetBlock=nblocks-1;`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`loop:`

Comments

(0)