Commitd1ed336

committed

Avoid double close of file handle in syslogger on win32

This causes an exception when running under a debugger or in particularwhen running on a debug version of Windows.Patch from MauMau

1 parent29f65a8 commitd1ed336Copy full SHA for d1ed336

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -593,8 +593,11 @@ SysLogger_Start(void)`
`593`	`593`	`errmsg("could not redirect stderr: %m")));`
`594`	`594`	`close(fd);`
`595`	`595`	`_setmode(_fileno(stderr),_O_BINARY);`
`596`		`-/* Now we are done with the write end of the pipe. */`
`597`		`-CloseHandle(syslogPipe[1]);`
	`596`	`+/*`
	`597`	`+ * Now we are done with the write end of the pipe.`
	`598`	`+ * CloseHandle() must not be called because the preceding`
	`599`	`+ * close() closes the underlying handle.`
	`600`	`+*/`
`598`	`601`	`syslogPipe[1]=0;`
`599`	`602`	`#endif`
`600`	`603`	`redirection_done= true;`

Comments

(0)