Commitd1d8e3f

adunstan

authored and

pull[bot]

committed

Fix version comparison in Version.pm

Version strings with unequal numbers of parts were being comparedincorrectly. We cure this by treating a missing part in the shorterversion as 0.per complaint from Jehan-Guillaume de Rorthais, but the fix is mine, nothis.Discussion:https://postgr.es/m/20220628225325.53d97b8d@karstBackpatch to release 14 where this code was introduced.

1 parentbf0d004 commitd1d8e3fCopy full SHA for d1d8e3f

File tree

1 file changed

-3

lines changed

src/test/perl/PostgreSQL
- Version.pm

1 file changed

-3

lines changed

`‎src/test/perl/PostgreSQL/Version.pm`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,12 @@ sub _version_cmp`
`123`	`123`
`124`	`124`	`for (my$idx = 0;;$idx++)`
`125`	`125`	`{`
`126`		`-return 0unless (defined$an->[$idx] &&defined$bn->[$idx]);`
`127`		`-return$an->[$idx]<=>$bn->[$idx]`
`128`		`-if ($an->[$idx]<=>$bn->[$idx]);`
	`126`	`+return 0`
	`127`	`+if ($idx >=@$an &&$idx >=@$bn);`
	`128`	`+# treat a missing number as 0`
	`129`	`+my ($anum,$bnum) = ($an->[$idx] \|\| 0,$bn->[$idx] \|\| 0);`
	`130`	`+return$anum<=>$bnum`
	`131`	`+if ($anum<=>$bnum);`
`129`	`132`	`}`
`130`	`133`	`}`
`131`	`134`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1d8e3f

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgreSQL/Version.pm`

0 commit comments