forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitd1bf86a
committed
Revert recent changes related to handling of 2PC files at recovery
This commit reverts8f67f99 (down to v13) andc3de0f9 (down tov17), as these are proving to not be completely correct regarding twoaspects:- In v17 and newer branches,c3de0f9's check for epoch handling isincorrect, and does not correctly handle frozen epochs. A logic closerto widen_snapshot_xid() should be used. The 2PC code should try tointegrate deeper with FullTransactionIds,5a1dfde being not enough.- In v13 and newer branches,8f67f99 is a workaround for the realissue, which is that we should not attempt CLOG lookups without reachingconsistency. This exists since728bd99, and this is reachable withProcessTwoPhaseBuffer() called by restoreTwoPhaseData() at the beginningof recovery.Per discussion with Noah Misch.Discussion:https://postgr.es/m/20250116010051.f3.nmisch@google.comBackpatch-through: 131 parent0671a71 commitd1bf86a
File tree
2 files changed
+55
-154
lines changed- src
- backend/access/transam
- test/recovery/t
2 files changed
+55
-154
lines changed0 commit comments
Comments
(0)