Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd1a4db8

Browse files
committed
Improve EXPLAIN's ability to cope with LATERAL references in plans.
push_child_plan/pop_child_plan didn't bother to adjust the "ancestors"list of parent plan nodes when descending to a child plan node. I thinkthis was okay when it was written, but it's not okay in the presence ofLATERAL references, since a subplan node could easily be returning aLATERAL value back up to the same nestloop node that provides the value.Per changed regression test results, the omission led to failure tointerpret Param nodes that have perfectly good interpretations.
1 parente1a6375 commitd1a4db8

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

‎src/backend/utils/adt/ruleutils.c

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2312,14 +2312,8 @@ push_child_plan(deparse_namespace *dpns, PlanState *ps,
23122312
/* Save state for restoration later */
23132313
*save_dpns=*dpns;
23142314

2315-
/*
2316-
* Currently we don't bother to adjust the ancestors list, because an
2317-
* OUTER_VAR or INNER_VAR reference really shouldn't contain any Params
2318-
* that would be set by the parent node itself. If we did want to adjust
2319-
* the list, lcons'ing dpns->planstate onto dpns->ancestors would be the
2320-
* appropriate thing --- and pop_child_plan would need to undo the change
2321-
* to the list.
2322-
*/
2315+
/* Link current plan node into ancestors list */
2316+
dpns->ancestors=lcons(dpns->planstate,dpns->ancestors);
23232317

23242318
/* Set attention on selected child */
23252319
set_deparse_planstate(dpns,ps);
@@ -2331,8 +2325,16 @@ push_child_plan(deparse_namespace *dpns, PlanState *ps,
23312325
staticvoid
23322326
pop_child_plan(deparse_namespace*dpns,deparse_namespace*save_dpns)
23332327
{
2328+
List*ancestors;
2329+
2330+
/* Get rid of ancestors list cell added by push_child_plan */
2331+
ancestors=list_delete_first(dpns->ancestors);
2332+
23342333
/* Restore fields changed by push_child_plan */
23352334
*dpns=*save_dpns;
2335+
2336+
/* Make sure dpns->ancestors is right (may be unnecessary) */
2337+
dpns->ancestors=ancestors;
23362338
}
23372339

23382340
/*

‎src/test/regress/expected/join.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3172,7 +3172,7 @@ explain (costs off)
31723172
Nested Loop
31733173
-> Seq Scan on int8_tbl a
31743174
-> Hash Left Join
3175-
Hash Cond: (x.q2 = ($0))
3175+
Hash Cond: (x.q2 = (a.q1))
31763176
-> Seq Scan on int8_tbl x
31773177
-> Hash
31783178
-> Seq Scan on int4_tbl y

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp