NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd1a2fa3

Amit Kapila

committed

Fix the initialization of atomic variable introduced by the

group clearing mechanism.Commit0e141c0 introduced initialization of atomic variable inInitProcess which means that it's not safe to look at it for backends thataren't currently in use. Fix that by initializing the same during postmasterstartup.Reported-by: Andres FreundAuthor: Amit KapilaBackpatch-through: 9.6Discussion:https://postgr.es/m/20181027104138.qmbbelopvy7cw2qv@alap3.anarazel.de

1 parent5574a01 commitd1a2fa3Copy full SHA for d1a2fa3

File tree

1 file changed

-1

lines changed

src/backend/storage/lmgr
- proc.c

1 file changed

-1

lines changed

`‎src/backend/storage/lmgr/proc.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,12 @@ InitProcGlobal(void)`
`266`	`266`
`267`	`267`	`/* Initialize lockGroupMembers list. */`
`268`	`268`	`dlist_init(&procs[i].lockGroupMembers);`
	`269`	`+`
	`270`	`+/*`
	`271`	`+ * Initialize the atomic variable, otherwise, it won't be safe to`
	`272`	`+ * access it for backends that aren't currently in use.`
	`273`	`+ */`
	`274`	`+pg_atomic_init_u32(&(procs[i].procArrayGroupNext),INVALID_PGPROCNO);`
`269`	`275`	`}`
`270`	`276`
`271`	`277`	`/*`
`@@ -399,7 +405,7 @@ InitProcess(void)`
`399`	`405`	`/* Initialize fields for group XID clearing. */`
`400`	`406`	`MyProc->procArrayGroupMember= false;`
`401`	`407`	`MyProc->procArrayGroupMemberXid=InvalidTransactionId;`
`402`		`-pg_atomic_init_u32(&MyProc->procArrayGroupNext,INVALID_PGPROCNO);`
	`408`	`+Assert(pg_atomic_read_u32(&MyProc->procArrayGroupNext)==INVALID_PGPROCNO);`
`403`	`409`
`404`	`410`	`/* Check that group locking fields are in a proper initial state. */`
`405`	`411`	`Assert(MyProc->lockGroupLeader==NULL);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1a2fa3

File tree

1 file changed

1 file changed

`‎src/backend/storage/lmgr/proc.c`

0 commit comments