NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd17b6df

committed

Fix knn-GiST queue comparison function to return heap tuples first.

The part of the comparison function that was supposed to keep heap tuplesahead of index items was backwards. It would not lead to incorrect results,but it is more efficient to return heap tuples first, before scanning moreindex pages, when both have the same distance.Alexander Korotkov

1 parent2e105de commitd17b6dfCopy full SHA for d17b6df

File tree

1 file changed

-2

lines changed

src/backend/access/gist
- gistscan.c

1 file changed

-2

lines changed

`‎src/backend/access/gist/gistscan.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,9 @@ pairingheap_GISTSearchItem_cmp(const pairingheap_node *a, const pairingheap_node`
`41`	`41`
`42`	`42`	`/* Heap items go before inner pages, to ensure a depth-first search */`
`43`	`43`	`if (GISTSearchItemIsHeap(sa)&& !GISTSearchItemIsHeap(sb))`
`44`		`-return-1;`
`45`		`-if (!GISTSearchItemIsHeap(sa)&&GISTSearchItemIsHeap(sb))`
`46`	`44`	`return1;`
	`45`	`+if (!GISTSearchItemIsHeap(sa)&&GISTSearchItemIsHeap(sb))`
	`46`	`+return-1;`
`47`	`47`
`48`	`48`	`return0;`
`49`	`49`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd17b6df

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistscan.c`

0 commit comments