NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd1763ea

committed

Change default of pg_stat_statements.track_planning to off.

Since v13 pg_stat_statements is allowed to track the planning time ofstatements when track_planning option is enabled. Its default was on.But this feature could cause more terrible spinlock contentions inpg_stat_statements. As a result of this, Robins Tharakan reported thatv13 beta1 showed ~45% performance drop at high DB connection counts(when compared with v12.3) during fully-cached SELECT-only test usingpgbench.To avoid this performance regression by the default setting,this commit changes default of pg_stat_statements.track_planning to off.Back-patch to v13 where pg_stat_statements.track_planning was introduced.Reported-by: Robins TharakanAuthor: Fujii MasaoReviewed-by: Julien RouhaudDiscussion:https://postgr.es/m/2895b53b033c47ccb22972b589050dd9@EX13D05UWC001.ant.amazon.com

1 parent947456a commitd1763eaCopy full SHA for d1763ea

File tree

4 files changed

+18

-3

lines changed

contrib/pg_stat_statements
- expected
  - pg_stat_statements.out
- pg_stat_statements.c
- sql
  - pg_stat_statements.sql
doc/src/sgml
- pgstatstatements.sgml

4 files changed

+18

-3

lines changed

`‎contrib/pg_stat_statements/expected/pg_stat_statements.out`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ CREATE EXTENSION pg_stat_statements;`
`3`	`3`	`-- simple and compound statements`
`4`	`4`	`--`
`5`	`5`	`SET pg_stat_statements.track_utility = FALSE;`
	`6`	`+SET pg_stat_statements.track_planning = TRUE;`
`6`	`7`	`SELECT pg_stat_statements_reset();`
`7`	`8`	`pg_stat_statements_reset`
`8`	`9`	`--------------------------`

`‎contrib/pg_stat_statements/pg_stat_statements.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ _PG_init(void)`
`442`	`442`	`"Selects whether planning duration is tracked by pg_stat_statements.",`
`443`	`443`	`NULL,`
`444`	`444`	`&pgss_track_planning,`
`445`		`-true,`
	`445`	`+false,`
`446`	`446`	`PGC_SUSET,`
`447`	`447`	`0,`
`448`	`448`	`NULL,`

`‎contrib/pg_stat_statements/sql/pg_stat_statements.sql`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ CREATE EXTENSION pg_stat_statements;`
`4`	`4`	`-- simple and compound statements`
`5`	`5`	`--`
`6`	`6`	`SETpg_stat_statements.track_utility= FALSE;`
	`7`	`+SETpg_stat_statements.track_planning= TRUE;`
`7`	`8`	`SELECT pg_stat_statements_reset();`
`8`	`9`
`9`	`10`	`SELECT1AS"int";`

`‎doc/src/sgml/pgstatstatements.sgml`

Lines changed: 15 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,8 @@`
`101`	`101`	`</para>`
`102`	`102`	`<para>`
`103`	`103`	`Number of times the statement was planned`
	`104`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`105`	`+ otherwise zero)`
`104`	`106`	`</para></entry>`
`105`	`107`	`</row>`
`106`	`108`
`@@ -110,6 +112,8 @@`
`110`	`112`	`</para>`
`111`	`113`	`<para>`
`112`	`114`	`Total time spent planning the statement, in milliseconds`
	`115`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`116`	`+ otherwise zero)`
`113`	`117`	`</para></entry>`
`114`	`118`	`</row>`
`115`	`119`
`@@ -119,6 +123,8 @@`
`119`	`123`	`</para>`
`120`	`124`	`<para>`
`121`	`125`	`Minimum time spent planning the statement, in milliseconds`
	`126`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`127`	`+ otherwise zero)`
`122`	`128`	`</para></entry>`
`123`	`129`	`</row>`
`124`	`130`
`@@ -128,6 +134,8 @@`
`128`	`134`	`</para>`
`129`	`135`	`<para>`
`130`	`136`	`Maximum time spent planning the statement, in milliseconds`
	`137`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`138`	`+ otherwise zero)`
`131`	`139`	`</para></entry>`
`132`	`140`	`</row>`
`133`	`141`
`@@ -137,6 +145,8 @@`
`137`	`145`	`</para>`
`138`	`146`	`<para>`
`139`	`147`	`Mean time spent planning the statement, in milliseconds`
	`148`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`149`	`+ otherwise zero)`
`140`	`150`	`</para></entry>`
`141`	`151`	`</row>`
`142`	`152`
`@@ -145,7 +155,10 @@`
`145`	`155`	`<structfield>stddev_plan_time</structfield> <type>double precision</type>`
`146`	`156`	`</para>`
`147`	`157`	`<para>`
`148`		`- Population standard deviation of time spent planning the statement, in milliseconds`
	`158`	`+ Population standard deviation of time spent planning the statement,`
	`159`	`+ in milliseconds`
	`160`	`+ (if <varname>pg_stat_statements.track_planning</varname> is enabled,`
	`161`	`+ otherwise zero)`
`149`	`162`	`</para></entry>`
`150`	`163`	`</row>`
`151`	`164`
`@@ -594,7 +607,7 @@`
`594`	`607`	`<para>`
`595`	`608`	`<varname>pg_stat_statements.track_planning</varname> controls whether`
`596`	`609`	`planning operations and duration are tracked by the module.`
`597`		`- The default value is <literal>on</literal>.`
	`610`	`+ The default value is <literal>off</literal>.`
`598`	`611`	`Only superusers can change this setting.`
`599`	`612`	`</para>`
`600`	`613`	`</listitem>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1763ea

File tree

4 files changed

4 files changed

`‎contrib/pg_stat_statements/expected/pg_stat_statements.out`

`‎contrib/pg_stat_statements/pg_stat_statements.c`

`‎contrib/pg_stat_statements/sql/pg_stat_statements.sql`

`‎doc/src/sgml/pgstatstatements.sgml`

0 commit comments