Commitd0d58f7

committed

Clarify docs on hot standby lock release

Andres Freund and Simon Riggs

1 parent634e148 commitd0d58f7Copy full SHA for d0d58f7

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1413,6 +1413,11 @@ GetSnapshotData(Snapshot snapshot)`
`1413`	`1413`	`* We don't worry about updating other counters, we want to keep this as`
`1414`	`1414`	`* simple as possible and leave GetSnapshotData() as the primary code for`
`1415`	`1415`	`* that bookkeeping.`
	`1416`	`+ *`
	`1417`	`+ * Note that if any transaction has overflowed its cached subtransactions`
	`1418`	`+ * then there is no real need include any subtransactions. That isn't a`
	`1419`	`+ * common enough case to worry about optimising the size of the WAL record,`
	`1420`	`+ * and we may wish to see that data for diagnostic purposes anyway.`
`1416`	`1421`	`*/`
`1417`	`1422`	`RunningTransactions`
`1418`	`1423`	`GetRunningTransactionData(void)`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -509,6 +509,10 @@ CheckRecoveryConflictDeadlock(void)`
`509`	`509`	`* RelationLockList, so we can keep track of the various entries made by`
`510`	`510`	`* the Startup process's virtual xid in the shared lock table.`
`511`	`511`	`*`
	`512`	`+ * We record the lock against the top-level xid, rather than individual`
	`513`	`+ * subtransaction xids. This means AccessExclusiveLocks held by aborted`
	`514`	`+ * subtransactions are not released as early as possible on standbys.`
	`515`	`+ *`
`512`	`516`	`* List elements use type xl_rel_lock, since the WAL record type exactly`
`513`	`517`	`* matches the information that we need to keep track of.`
`514`	`518`	`*`
`@@ -642,8 +646,8 @@ StandbyReleaseAllLocks(void)`
`642`	`646`
`643`	`647`	`/*`
`644`	`648`	`* StandbyReleaseOldLocks`
`645`		`- *Release standby locks held by XIDs that aren't running, as long`
`646`		`- *as they're not prepared transactions.`
	`649`	`+ *Release standby locks held bytop-levelXIDs that aren't running,`
	`650`	`+ *aslong asthey're not prepared transactions.`
`647`	`651`	`*/`
`648`	`652`	`void`
`649`	`653`	`StandbyReleaseOldLocks(intnxids,TransactionId*xids)`

Comments

(0)