Commitd03d754

committed

Use macros instead of hardcoded offsets for LWLock initialization

This makes the code slightly easier to follow, as the initializationrelies on an offset that overlapped with an equivalent set of macrosdefined, which are used in other places already.Author: Japin LiDiscussion:https://postgr.es/m/MEYP282MB1669FB410006758402F2C3A2B6E00@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

1 parent789b938 commitd03d754Copy full SHA for d03d754

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -525,18 +525,17 @@ InitializeLWLocks(void)`
`525`	`525`	`LWLockInitialize(&lock->lock,id);`
`526`	`526`
`527`	`527`	`/* Initialize buffer mapping LWLocks in main array */`
`528`		`-lock=MainLWLockArray+NUM_INDIVIDUAL_LWLOCKS;`
	`528`	`+lock=MainLWLockArray+BUFFER_MAPPING_LWLOCK_OFFSET;`
`529`	`529`	`for (id=0;id<NUM_BUFFER_PARTITIONS;id++,lock++)`
`530`	`530`	`LWLockInitialize(&lock->lock,LWTRANCHE_BUFFER_MAPPING);`
`531`	`531`
`532`	`532`	`/* Initialize lmgrs' LWLocks in main array */`
`533`		`-lock=MainLWLockArray+NUM_INDIVIDUAL_LWLOCKS+NUM_BUFFER_PARTITIONS;`
	`533`	`+lock=MainLWLockArray+LOCK_MANAGER_LWLOCK_OFFSET;`
`534`	`534`	`for (id=0;id<NUM_LOCK_PARTITIONS;id++,lock++)`
`535`	`535`	`LWLockInitialize(&lock->lock,LWTRANCHE_LOCK_MANAGER);`
`536`	`536`
`537`	`537`	`/* Initialize predicate lmgrs' LWLocks in main array */`
`538`		`-lock=MainLWLockArray+NUM_INDIVIDUAL_LWLOCKS+`
`539`		`-NUM_BUFFER_PARTITIONS+NUM_LOCK_PARTITIONS;`
	`538`	`+lock=MainLWLockArray+PREDICATELOCK_MANAGER_LWLOCK_OFFSET;`
`540`	`539`	`for (id=0;id<NUM_PREDICATELOCK_PARTITIONS;id++,lock++)`
`541`	`540`	`LWLockInitialize(&lock->lock,LWTRANCHE_PREDICATE_LOCK_MANAGER);`
`542`	`541`

Comments

(0)