NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd034e9b

committed

Fix hot standby bug with GiST scans.

Don't reset the rightlink of a page when replaying a page update record.This was a leftover from pre-hot standby days, when it was not possible tohave scans concurrent with WAL replay. Resetting the right-link was notnecessary back then either, but it was done for the sake of tidiness. Butwith hot standby, it's wrong, because a concurrent scan might still need it.Backpatch all versions with hot standby, 9.0 and above.

1 parent5c26ab6 commitd034e9bCopy full SHA for d034e9b

File tree

1 file changed

-1

lines changed

src/backend/access/gist
- gistxlog.c

1 file changed

-1

lines changed

`‎src/backend/access/gist/gistxlog.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,6 @@ gistRedoPageUpdateRecord(XLogRecPtr lsn, XLogRecord *record, bool isnewroot)`
`253`	`253`	`*/`
`254`	`254`	`GistPageSetLeaf(page);`
`255`	`255`
`256`		`-GistPageGetOpaque(page)->rightlink=InvalidBlockNumber;`
`257`	`256`	`PageSetLSN(page,lsn);`
`258`	`257`	`PageSetTLI(page,ThisTimeLineID);`
`259`	`258`	`MarkBufferDirty(buffer);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd034e9b

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistxlog.c`

0 commit comments