NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd01fc51

committed

Initialize replication_slot_catalog_xmin in procarray

Although not confirmed and probably rare, if the newly allocated memoryis not already zero, this could possibly have caused some problems.Also reorder the initializations slightly so they match the order of thestruct definition.Author: Wong, Yi Wen <yiwong@amazon.com>Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>

1 parentdce90c7 commitd01fc51Copy full SHA for d01fc51

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- procarray.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/procarray.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -239,13 +239,14 @@ CreateSharedProcArray(void)`
`239`	`239`	`*/`
`240`	`240`	`procArray->numProcs=0;`
`241`	`241`	`procArray->maxProcs=PROCARRAY_MAXPROCS;`
`242`		`-procArray->replication_slot_xmin=InvalidTransactionId;`
`243`	`242`	`procArray->maxKnownAssignedXids=TOTAL_MAX_CACHED_SUBXIDS;`
`244`	`243`	`procArray->numKnownAssignedXids=0;`
`245`	`244`	`procArray->tailKnownAssignedXids=0;`
`246`	`245`	`procArray->headKnownAssignedXids=0;`
`247`	`246`	`SpinLockInit(&procArray->known_assigned_xids_lck);`
`248`	`247`	`procArray->lastOverflowedXid=InvalidTransactionId;`
	`248`	`+procArray->replication_slot_xmin=InvalidTransactionId;`
	`249`	`+procArray->replication_slot_catalog_xmin=InvalidTransactionId;`
`249`	`250`	`}`
`250`	`251`
`251`	`252`	`allProcs=ProcGlobal->allProcs;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd01fc51

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procarray.c`

0 commit comments