NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitd003213

committed

Don't run in CacheMemoryContext longer than necessary.

1 parent72164e8 commitd003213Copy full SHA for d003213

File tree

1 file changed

+13

-15

lines changed

src/backend/catalog
- heap.c

1 file changed

+13

-15

lines changed

`‎src/backend/catalog/heap.c`

Lines changed: 13 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.134 2000/06/28 03:31:22 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/heap.c,v 1.135 2000/07/02 04:46:09 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -166,12 +166,11 @@ heap_create(char *relname,`
`166`	`166`	`{`
`167`	`167`	`staticunsignedintuniqueId=0;`
`168`	`168`
`169`		`-inti;`
`170`	`169`	`Oidrelid;`
`171`	`170`	`Relationrel;`
`172`		`-intlen;`
`173`	`171`	`boolnailme= false;`
`174`	`172`	`intnatts=tupDesc->natts;`
	`173`	`+inti;`
`175`	`174`	`MemoryContextoldcxt;`
`176`	`175`
`177`	`176`	`/* ----------------`
`@@ -236,13 +235,13 @@ heap_create(char *relname,`
`236`	`235`	`*allocate a new relation descriptor.`
`237`	`236`	`* ----------------`
`238`	`237`	`*/`
`239`		`-len=sizeof(RelationData);`
`240`		`-`
`241`		`-rel= (Relation)palloc(len);`
`242`		`-MemSet((char*)rel,0,len);`
	`238`	`+rel= (Relation)palloc(sizeof(RelationData));`
	`239`	`+MemSet((char*)rel,0,sizeof(RelationData));`
`243`	`240`	`rel->rd_fd=-1;/* table is not open */`
`244`	`241`	`rel->rd_unlinked= true;/* table is not created yet */`
`245`	`242`
	`243`	`+RelationSetReferenceCount(rel,1);`
	`244`	`+`
`246`	`245`	`/*`
`247`	`246`	`* create a new tuple descriptor from the one passed in`
`248`	`247`	`*/`
`@@ -257,14 +256,11 @@ heap_create(char *relname,`
`257`	`256`	`if (nailme)`
`258`	`257`	`rel->rd_isnailed= true;`
`259`	`258`
`260`		`-RelationSetReferenceCount(rel,1);`
`261`		`-`
`262`		`-rel->rd_rel= (Form_pg_class)palloc(sizeof*rel->rd_rel);`
`263`		`-`
`264`	`259`	`/* ----------------`
`265`	`260`	`*initialize the fields of our new relation descriptor`
`266`	`261`	`* ----------------`
`267`	`262`	`*/`
	`263`	`+rel->rd_rel= (Form_pg_class)palloc(sizeof*rel->rd_rel);`
`268`	`264`	`MemSet((char)rel->rd_rel,0,sizeofrel->rd_rel);`
`269`	`265`	`strcpy(RelationGetPhysicalRelationName(rel),relname);`
`270`	`266`	`rel->rd_rel->relkind=RELKIND_UNCATALOGED;`
`@@ -283,10 +279,14 @@ heap_create(char *relname,`
`283`	`279`	`rel->rd_rel->reltype=relid;`
`284`	`280`	`}`
`285`	`281`
	`282`	`+/* ----------------`
	`283`	`+ *done building relcache entry.`
	`284`	`+ * ----------------`
	`285`	`+ */`
	`286`	`+MemoryContextSwitchTo(oldcxt);`
	`287`	`+`
`286`	`288`	`/* ----------------`
`287`	`289`	`*have the storage manager create the relation.`
`288`		`- *`
`289`		`- * XXX shouldn't we switch out of CacheMemoryContext for that?`
`290`	`290`	`* ----------------`
`291`	`291`	`*/`
`292`	`292`
`@@ -296,8 +296,6 @@ heap_create(char *relname,`
`296`	`296`
`297`	`297`	`RelationRegisterRelation(rel);`
`298`	`298`
`299`		`-MemoryContextSwitchTo(oldcxt);`
`300`		`-`
`301`	`299`	`returnrel;`
`302`	`300`	`}`
`303`	`301`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd003213

File tree

1 file changed

1 file changed

`‎src/backend/catalog/heap.c`

0 commit comments