forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitcfc878a
committed
Revert misguided change to postgres_fdw FOR UPDATE/SHARE code.
In commit462bd95, I changed postgres_fdwto rely on get_plan_rowmark() instead of get_parse_rowmark(). I stillthink that's a good idea in the long run, but as Etsuro Fujita pointed out,it doesn't work today because planner.c forces PlanRowMarks to havemarkType = ROW_MARK_COPY for all foreign tables. There's no urgent reasonto change this in the back branches, so let's just revert that part ofyesterday's commit rather than trying to design a better solution undertime pressure.Also, add a regression test case showing what postgres_fdw does with FORUPDATE/SHARE. I'd blithely assumed there was one already, else I'd haverealized yesterday that this code didn't work.1 parent2ae8a01 commitcfc878a
File tree
3 files changed
+45
-10
lines changed- contrib/postgres_fdw
- expected
- sql
3 files changed
+45
-10
lines changedLines changed: 33 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
231 | 231 |
| |
232 | 232 |
| |
233 | 233 |
| |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
234 | 267 |
| |
235 | 268 |
| |
236 | 269 |
| |
|
Lines changed: 7 additions & 10 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
819 | 819 |
| |
820 | 820 |
| |
821 | 821 |
| |
822 |
| - | |
| 822 | + | |
823 | 823 |
| |
824 | 824 |
| |
825 | 825 |
| |
| |||
832 | 832 |
| |
833 | 833 |
| |
834 | 834 |
| |
835 |
| - | |
| 835 | + | |
836 | 836 |
| |
837 |
| - | |
838 |
| - | |
839 |
| - | |
840 |
| - | |
841 |
| - | |
842 |
| - | |
| 837 | + | |
| 838 | + | |
843 | 839 |
| |
844 | 840 |
| |
845 |
| - | |
846 |
| - | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
847 | 844 |
| |
848 | 845 |
| |
849 | 846 |
| |
|
Lines changed: 5 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
145 | 145 |
| |
146 | 146 |
| |
147 | 147 |
| |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
148 | 153 |
| |
149 | 154 |
| |
150 | 155 |
| |
|
0 commit comments
Comments
(0)