Commitcf74b6e

committed

Fix some BufFileRead() error reporting

Remove "%m" from error messages where errno would be bogus. Add shortread byte counts where appropriate.This is equivalent to what was done in7897e3b, but some code was apparentlydeveloped concurrently to that and not updated accordingly.Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/f3501945-c591-8cc3-5ef0-b72a2e0eaa9c@enterprisedb.com

1 parent787db4b commitcf74b6eCopy full SHA for cf74b6e

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,8 @@ SendBackupManifest(backup_manifest_info *manifest)`
`358`	`358`	`if (rc!=bytes_to_read)`
`359`	`359`	`ereport(ERROR,`
`360`	`360`	`(errcode_for_file_access(),`
`361`		`-errmsg("could not read from temporary file: %m")));`
	`361`	`+errmsg("could not read from temporary file: read only %zu of %zu bytes",`
	`362`	`+rc,bytes_to_read)));`
`362`	`363`	`pq_putmessage('d',manifestbuf,bytes_to_read);`
`363`	`364`	`manifest_bytes_done+=bytes_to_read;`
`364`	`365`	`}`

Comments

(0)