Commitcf13ca4

authored and

committed

Standardize type of extend_by counter

The counter of extend_by loops is mixed int and uint32. Fix bystandardizing from int to uint32, to match the extend_by variable.Fixup for31966b1.Author: Ranier Vilela <ranier.vf@gmail.com>Reviewed-by: Gurjeet Singh <gurjeet@singh.im>Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/CAEudQAqHG-JP-YnG54ftL_b7v6-57rMKwET_MSvEoen0UHuPig@mail.gmail.com

1 parenta4999de commitcf13ca4Copy full SHA for cf13ca4

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,7 @@ ExtendBufferedRelTo(BufferManagerRelation bmr,`
`955`	`955`	`current_size=first_block+extended_by;`
`956`	`956`	`Assert(num_pages!=0\|\|current_size >=extend_to);`
`957`	`957`
`958`		`-for (inti=0;i<extended_by;i++)`
	`958`	`+for (uint32i=0;i<extended_by;i++)`
`959`	`959`	`{`
`960`	`960`	`if (first_block+i!=extend_to-1)`
`961`	`961`	`ReleaseBuffer(buffers[i]);`
`@@ -1938,7 +1938,7 @@ ExtendBufferedRelShared(BufferManagerRelation bmr,`
`1938`	`1938`	`* This needs to happen before we extend the relation, because as soon as`
`1939`	`1939`	`* we do, other backends can start to read in those pages.`
`1940`	`1940`	`*/`
`1941`		`-for (inti=0;i<extend_by;i++)`
	`1941`	`+for (uint32i=0;i<extend_by;i++)`
`1942`	`1942`	`{`
`1943`	`1943`	`Buffervictim_buf=buffers[i];`
`1944`	`1944`	`BufferDesc*victim_buf_hdr=GetBufferDescriptor(victim_buf-1);`
`@@ -2070,7 +2070,7 @@ ExtendBufferedRelShared(BufferManagerRelation bmr,`
`2070`	`2070`	`io_start,extend_by);`
`2071`	`2071`
`2072`	`2072`	`/* Set BM_VALID, terminate IO, and wake up any waiters */`
`2073`		`-for (inti=0;i<extend_by;i++)`
	`2073`	`+for (uint32i=0;i<extend_by;i++)`
`2074`	`2074`	`{`
`2075`	`2075`	`Bufferbuf=buffers[i];`
`2076`	`2076`	`BufferDesc*buf_hdr=GetBufferDescriptor(buf-1);`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ ExtendBufferedRelLocal(BufferManagerRelation bmr,`
`360`	`360`	`relpath(bmr.smgr->smgr_rlocator,fork),`
`361`	`361`	`MaxBlockNumber)));`
`362`	`362`
`363`		`-for (inti=0;i<extend_by;i++)`
	`363`	`+for (uint32i=0;i<extend_by;i++)`
`364`	`364`	`{`
`365`	`365`	`intvictim_buf_id;`
`366`	`366`	`BufferDesc*victim_buf_hdr;`
`@@ -416,7 +416,7 @@ ExtendBufferedRelLocal(BufferManagerRelation bmr,`
`416`	`416`	`pgstat_count_io_op_time(IOOBJECT_TEMP_RELATION,IOCONTEXT_NORMAL,IOOP_EXTEND,`
`417`	`417`	`io_start,extend_by);`
`418`	`418`
`419`		`-for (inti=0;i<extend_by;i++)`
	`419`	`+for (uint32i=0;i<extend_by;i++)`
`420`	`420`	`{`
`421`	`421`	`Bufferbuf=buffers[i];`
`422`	`422`	`BufferDesc*buf_hdr;`

Comments

(0)