NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitcecb590

committed

Allocate all entries in the serializable xid hash up-front, so that you don't

run out of shared memory when you try to assign an xid to a transaction.Kevin Grittner

1 parent2ad0348 commitcecb590Copy full SHA for cecb590

File tree

1 file changed

-5

lines changed

src/backend/storage/lmgr
- predicate.c

1 file changed

-5

lines changed

`‎src/backend/storage/lmgr/predicate.c`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1018,7 +1018,6 @@ InitPredicateLocks(void)`
`1018`	`1018`	`* PredicateLockShmemSize!`
`1019`	`1019`	`*/`
`1020`	`1020`	`max_table_size= (MaxBackends+max_prepared_xacts);`
`1021`		`-init_table_size=max_table_size /2;`
`1022`	`1021`
`1023`	`1022`	`/*`
`1024`	`1023`	`* Allocate a list to hold information on transactions participating in`
`@@ -1029,7 +1028,6 @@ InitPredicateLocks(void)`
`1029`	`1028`	`* be summarized for storage in SLRU and the "dummy" transaction.`
`1030`	`1029`	`*/`
`1031`	`1030`	`max_table_size *=10;`
`1032`		`-init_table_size *=10;`
`1033`	`1031`
`1034`	`1032`	`PredXact=ShmemInitStruct("PredXactList",`
`1035`	`1033`	`PredXactListDataSize,`
`@@ -1092,7 +1090,7 @@ InitPredicateLocks(void)`
`1092`	`1090`	`hash_flags= (HASH_ELEM \|HASH_FUNCTION);`
`1093`	`1091`
`1094`	`1092`	`SerializableXidHash=ShmemInitHash("SERIALIZABLEXID hash",`
`1095`		`-init_table_size,`
	`1093`	`+max_table_size,`
`1096`	`1094`	`max_table_size,`
`1097`	`1095`	`&info,`
`1098`	`1096`	`hash_flags);`
`@@ -1595,10 +1593,10 @@ RegisterPredicateLockingXid(const TransactionId xid)`
`1595`	`1593`	`&sxidtag,`
`1596`	`1594`	`HASH_ENTER,&found);`
`1597`	`1595`	`if (!sxid)`
	`1596`	`+/* This should not be possible, based on allocation. */`
`1598`	`1597`	`ereport(ERROR,`
`1599`	`1598`	`(errcode(ERRCODE_OUT_OF_MEMORY),`
`1600`		`-errmsg("out of shared memory"),`
`1601`		`-errhint("You might need to increase max_predicate_locks_per_transaction.")));`
	`1599`	`+errmsg("out of shared memory")));`
`1602`	`1600`
`1603`	`1601`	`Assert(!found);`
`1604`	`1602`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcecb590

File tree

1 file changed

1 file changed

`‎src/backend/storage/lmgr/predicate.c`

0 commit comments