Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitcea5624

Browse files
committed
Fix instability in contrib/bloom TAP tests.
It turns out that the instability complained of in commitd3c09b9has an embarrassingly simple explanation. The test script waits forthe standby to flush incoming WAL to disk, but it should wait forthe WAL to be replayed, since we are testing for the effects of thatto be visible.While at it, use wait_for_catchup instead of reinventing that logic,and adjust $Test::Builder::Level to improve future error reports.Back-patch to v12 where the necessary infrastructure came in(cf. aforesaid commit). Also back-patch7d1aa6b so that thetest will actually get run.Discussion:https://postgr.es/m/2854602.1632852664@sss.pgh.pa.us
1 parent2f283d0 commitcea5624

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

‎contrib/bloom/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ PGFILEDESC = "bloom access method - signature file based index"
1616

1717
REGRESS = bloom
1818

19-
# Disable TAP tests for this module for now, as these are unstable on several
20-
# buildfarm environments.
21-
# TAP_TESTS = 1
19+
TAP_TESTS = 1
2220

2321
ifdefUSE_PGXS
2422
PG_CONFIG = pg_config

‎contrib/bloom/t/001_wal.pl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,10 @@ sub test_index_replay
1616
{
1717
my ($test_name) =@_;
1818

19+
local$Test::Builder::Level =$Test::Builder::Level + 1;
20+
1921
# Wait for standby to catch up
20-
my$applname =$node_standby->name;
21-
my$caughtup_query =
22-
"SELECT pg_current_wal_lsn() <= write_lsn FROM pg_stat_replication WHERE application_name = '$applname';";
23-
$node_primary->poll_query_until('postgres',$caughtup_query)
24-
ordie"Timed out while waiting for standby 1 to catch up";
22+
$node_primary->wait_for_catchup($node_standby);
2523

2624
my$queries =qq(SET enable_seqscan=off;
2725
SET enable_bitmapscan=on;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp