Commitce413eb

committed

Make new replication slot test code even less racy

Further fix the test code inead9e51, this time by waiting untilthe checkpoint has completed before moving on; this ensures that theWAL segment removal has already happened when we create the next slot.Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>Discussion:https://postgr.es/m/20210719.111318.2042379313472032754.horikyota.ntt@gmail.com

1 parentbfa2a92 commitce413ebCopy full SHA for ce413eb

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use PostgresNode;`
`9`	`9`
`10`	`10`	`use File::Pathqw(rmtree);`
`11`		`-use Test::Moretests=>15;`
	`11`	`+use Test::Moretests=>16;`
`12`	`12`	`use Time::HiResqw(usleep);`
`13`	`13`
`14`	`14`	`$ENV{PGDATABASE} ='postgres';`
`@@ -198,6 +198,19 @@`
`198`	`198`	`is($result,"rep1\|f\|t\|lost\|",`
`199`	`199`	`'check that the slot became inactive and the state "lost" persists');`
`200`	`200`
	`201`	`+# Wait until current checkpoint ends`
	`202`	`+my$checkpoint_ended = 0;`
	`203`	`+for (my$i = 0;$i < 10000;$i++)`
	`204`	`+{`
	`205`	`+if (find_in_log($node_master,"checkpoint complete:",$logstart))`
	`206`	`+{`
	`207`	`+$checkpoint_ended = 1;`
	`208`	`+last;`
	`209`	`+}`
	`210`	`+usleep(100_000);`
	`211`	`+}`
	`212`	`+ok($checkpoint_ended,'waited for checkpoint to end');`
	`213`	`+`
`201`	`214`	`# The invalidated slot shouldn't keep the old-segment horizon back;`
`202`	`215`	`# see bug #17103: https://postgr.es/m/17103-004130e8f27782c9@postgresql.org`
`203`	`216`	`# Test for this by creating a new slot and comparing its restart LSN`

Comments

(0)