NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitce093aa

committed

Fix broken MemoizePath support in reparameterize_path().

It neglected to recurse to the subpath, meaning you'd get backa path identical to the input. This could produce wrong queryresults if the omission meant that the subpath fails to enforcesome join clause it should be enforcing. We don't have a testcase for this at the moment, but the code is obviously brokenand the fix is equally obvious. Back-patch to v14 whereMemoize was introduced.Richard GuoDiscussion:https://postgr.es/m/CAMbWs4_R=ORpz=Lkn2q3ebPC5EuWyfZF+tmfCPVLBVK5W39mHA@mail.gmail.com

1 parentec3daee commitce093aaCopy full SHA for ce093aa

File tree

1 file changed

-1

lines changed

src/backend/optimizer/util
- pathnode.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/util/pathnode.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3937,9 +3937,15 @@ reparameterize_path(PlannerInfo root, Path path,`
`3937`	`3937`	`caseT_Memoize:`
`3938`	`3938`	`{`
`3939`	`3939`	`MemoizePathmpath= (MemoizePath)path;`
	`3940`	`+Path*spath=mpath->subpath;`
`3940`	`3941`
	`3942`	`+spath=reparameterize_path(root,spath,`
	`3943`	`+required_outer,`
	`3944`	`+loop_count);`
	`3945`	`+if (spath==NULL)`
	`3946`	`+returnNULL;`
`3941`	`3947`	`return (Path*)create_memoize_path(root,rel,`
`3942`		`-mpath->subpath,`
	`3948`	`+spath,`
`3943`	`3949`	`mpath->param_exprs,`
`3944`	`3950`	`mpath->hash_operators,`
`3945`	`3951`	`mpath->singlerow,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitce093aa

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/pathnode.c`

0 commit comments