Commitcdaf4a4

committed

Increase test coverage in RI_FKey_pk_upd_check_required()

This checks the case where the primary key has at least one nullcolumn.Reviewed-by: Alvaro Herrera <alvherre@2ndquadrant.com>Reviewed-by: Mi Tar <mmitar@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/7ae17c95-0c99-d420-032a-c271f510112b@2ndquadrant.com/

1 parent74bd066 commitcdaf4a4Copy full SHA for cdaf4a4

File tree

+43

-0

lines changed

+43

-0

lines changed

Lines changed: 24 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -397,6 +397,30 @@ SELECT * from FKTABLE;`
`397`	`397`	`\| 3 \| 4 \| 5`
`398`	`398`	`(5 rows)`
`399`	`399`
	`400`	`+DROP TABLE FKTABLE;`
	`401`	`+DROP TABLE PKTABLE;`
	`402`	`+-- restrict with null values`
	`403`	`+CREATE TABLE PKTABLE ( ptest1 int, ptest2 int, ptest3 int, ptest4 text, UNIQUE(ptest1, ptest2, ptest3) );`
	`404`	`+CREATE TABLE FKTABLE ( ftest1 int, ftest2 int, ftest3 int, ftest4 int, CONSTRAINT constrname3`
	`405`	`+FOREIGN KEY(ftest1, ftest2, ftest3) REFERENCES PKTABLE (ptest1, ptest2, ptest3));`
	`406`	`+INSERT INTO PKTABLE VALUES (1, 2, 3, 'test1');`
	`407`	`+INSERT INTO PKTABLE VALUES (1, 3, NULL, 'test2');`
	`408`	`+INSERT INTO PKTABLE VALUES (2, NULL, 4, 'test3');`
	`409`	`+INSERT INTO FKTABLE VALUES (1, 2, 3, 1);`
	`410`	`+DELETE FROM PKTABLE WHERE ptest1 = 2;`
	`411`	`+SELECT * FROM PKTABLE;`
	`412`	`+ ptest1 \| ptest2 \| ptest3 \| ptest4`
	`413`	`+--------+--------+--------+--------`
	`414`	`+ 1 \| 2 \| 3 \| test1`
	`415`	`+ 1 \| 3 \| \| test2`
	`416`	`+(2 rows)`
	`417`	`+`
	`418`	`+SELECT * FROM FKTABLE;`
	`419`	`+ ftest1 \| ftest2 \| ftest3 \| ftest4`
	`420`	`+--------+--------+--------+--------`
	`421`	`+ 1 \| 2 \| 3 \| 1`
	`422`	`+(1 row)`
	`423`	`+`
`400`	`424`	`DROP TABLE FKTABLE;`
`401`	`425`	`DROP TABLE PKTABLE;`
`402`	`426`	`-- cascade update/delete`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -260,6 +260,25 @@ SELECT * from FKTABLE;`
`260`	`260`	`DROPTABLE FKTABLE;`
`261`	`261`	`DROPTABLE PKTABLE;`
`262`	`262`
	`263`	`+-- restrict with null values`
	`264`	`+CREATETABLEPKTABLE ( ptest1int, ptest2int, ptest3int, ptest4text, UNIQUE(ptest1, ptest2, ptest3) );`
	`265`	`+CREATETABLEFKTABLE ( ftest1int, ftest2int, ftest3int, ftest4int,CONSTRAINT constrname3`
	`266`	`+FOREIGN KEY(ftest1, ftest2, ftest3)REFERENCES PKTABLE (ptest1, ptest2, ptest3));`
	`267`	`+`
	`268`	`+INSERT INTO PKTABLEVALUES (1,2,3,'test1');`
	`269`	`+INSERT INTO PKTABLEVALUES (1,3,NULL,'test2');`
	`270`	`+INSERT INTO PKTABLEVALUES (2,NULL,4,'test3');`
	`271`	`+`
	`272`	`+INSERT INTO FKTABLEVALUES (1,2,3,1);`
	`273`	`+`
	`274`	`+DELETEFROM PKTABLEWHERE ptest1=2;`
	`275`	`+`
	`276`	`+SELECT*FROM PKTABLE;`
	`277`	`+SELECT*FROM FKTABLE;`
	`278`	`+`
	`279`	`+DROPTABLE FKTABLE;`
	`280`	`+DROPTABLE PKTABLE;`
	`281`	`+`
`263`	`282`	`-- cascade update/delete`
`264`	`283`	`CREATETABLEPKTABLE ( ptest1int, ptest2int, ptest3int, ptest4text,PRIMARY KEY(ptest1, ptest2, ptest3) );`
`265`	`284`	`CREATETABLEFKTABLE ( ftest1int, ftest2int, ftest3int, ftest4int,CONSTRAINT constrname3`

Comments

(0)