Commitcdaeff9

committed

XLogRegisterData, XLogRegisterBufData void * argument for binary data

Change XLogRegisterData() and XLogRegisterBufData() functions to takevoid * for binary data instead of char *. This will remove the needfor numerous casts (done in a separate commit for clarity).Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>Discussion:https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org

1 parent773c51d commitcdaeff9Copy full SHA for cdaeff9

File tree

-7

lines changed

-7

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -586,13 +586,13 @@ void XLogRegisterBuffer(uint8 block_id, Buffer buf, uint8 flags);`
`586`	`586`	`XLogRegisterBufData() is included in the WAL record even if a full-page`
`587`	`587`	`image is taken.`
`588`	`588`
`589`		`-void XLogRegisterData(constchar *data, int len);`
	`589`	`+void XLogRegisterData(constvoid *data, int len);`
`590`	`590`
`591`	`591`	`XLogRegisterData is used to include arbitrary data in the WAL record. If`
`592`	`592`	`XLogRegisterData() is called multiple times, the data are appended, and`
`593`	`593`	`will be made available to the redo routine as one contiguous chunk.`
`594`	`594`
`595`		`-void XLogRegisterBufData(uint8 block_id, constchar *data, int len);`
	`595`	`+void XLogRegisterBufData(uint8 block_id, constvoid *data, int len);`
`596`	`596`
`597`	`597`	`XLogRegisterBufData is used to include data associated with a particular`
`598`	`598`	`buffer that was registered earlier with XLogRegisterBuffer(). If`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ XLogRegisterBlock(uint8 block_id, RelFileLocator *rlocator, ForkNumber forknum,`
`361`	`361`	`* XLogRecGetData().`
`362`	`362`	`*/`
`363`	`363`	`void`
`364`		`-XLogRegisterData(constchar*data,uint32len)`
	`364`	`+XLogRegisterData(constvoid*data,uint32len)`
`365`	`365`	`{`
`366`	`366`	`XLogRecData*rdata;`
`367`	`367`
`@@ -402,7 +402,7 @@ XLogRegisterData(const char *data, uint32 len)`
`402`	`402`	`* limited)`
`403`	`403`	`*/`
`404`	`404`	`void`
`405`		`-XLogRegisterBufData(uint8block_id,constchar*data,uint32len)`
	`405`	`+XLogRegisterBufData(uint8block_id,constvoid*data,uint32len)`
`406`	`406`	`{`
`407`	`407`	`registered_buffer*regbuf;`
`408`	`408`	`XLogRecData*rdata;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ typedef struct xl_end_of_recovery`
`312`	`312`	`typedefstructXLogRecData`
`313`	`313`	`{`
`314`	`314`	`structXLogRecDatanext;/ next struct in chain, or NULL */`
`315`		`-constchardata;/ start of rmgr data to include */`
	`315`	`+constvoiddata;/ start of rmgr data to include */`
`316`	`316`	`uint32len;/* length of rmgr data to include */`
`317`	`317`	`}XLogRecData;`
`318`	`318`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,12 +45,12 @@ extern void XLogBeginInsert(void);`
`45`	`45`	`externvoidXLogSetRecordFlags(uint8flags);`
`46`	`46`	`externXLogRecPtrXLogInsert(RmgrIdrmid,uint8info);`
`47`	`47`	`externvoidXLogEnsureRecordSpace(intmax_block_id,intndatas);`
`48`		`-externvoidXLogRegisterData(constchar*data,uint32len);`
	`48`	`+externvoidXLogRegisterData(constvoid*data,uint32len);`
`49`	`49`	`externvoidXLogRegisterBuffer(uint8block_id,Bufferbuffer,uint8flags);`
`50`	`50`	`externvoidXLogRegisterBlock(uint8block_id,RelFileLocator*rlocator,`
`51`	`51`	`ForkNumberforknum,BlockNumberblknum,constPageData*page,`
`52`	`52`	`uint8flags);`
`53`		`-externvoidXLogRegisterBufData(uint8block_id,constchar*data,uint32len);`
	`53`	`+externvoidXLogRegisterBufData(uint8block_id,constvoid*data,uint32len);`
`54`	`54`	`externvoidXLogResetInsertion(void);`
`55`	`55`	`externboolXLogCheckBufferNeedsBackup(Bufferbuffer);`
`56`	`56`

Comments

(0)