NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitcdaedfc

committed

Support parenthesized syntax for CLUSTER without a table name.

b5913f6 added a parenthesized syntax for CLUSTER, but itrequires specifying a table name. This is unlike commands such asVACUUM and ANALYZE, which do not require specifying a table in theparenthesized syntax. This change resolves this inconsistency.This is preparatory work for a follow-up commit that will move theunparenthesized syntax to the "Compatibility" section of theCLUSTER documentation.Reviewed-by: Melanie Plageman, Michael PaquierDiscussion:https://postgr.es/m/CAAKRu_bc5uHieG1976kGqJKxyWtyQt9yvktjsVX%2Bi7NOigDjOA%40mail.gmail.com

1 parent018b61f commitcdaedfcCopy full SHA for cdaedfc

File tree

2 files changed

+12

-2

lines changed

doc/src/sgml/ref
- cluster.sgml
src/backend/parser
- gram.y

2 files changed

+12

-2

lines changed

`‎doc/src/sgml/ref/cluster.sgml`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ PostgreSQL documentation`
`21`	`21`
`22`	`22`	`<refsynopsisdiv>`
`23`	`23`	`<synopsis>`
`24`		`-CLUSTER [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] <replaceable class="parameter">table_name</replaceable> [ USING <replaceable class="parameter">index_name</replaceable> ]`
	`24`	`+CLUSTER [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ][<replaceable class="parameter">table_name</replaceable> [ USING <replaceable class="parameter">index_name</replaceable> ] ]`
`25`	`25`	`CLUSTER [ VERBOSE ] [ <replaceable class="parameter">table_name</replaceable> [ USING <replaceable class="parameter">index_name</replaceable> ] ]`
`26`	`26`
`27`	`27`	`<phrase>where <replaceable class="parameter">option</replaceable> can be one of:</phrase>`

`‎src/backend/parser/gram.y`

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11553,7 +11553,7 @@ CreateConversionStmt:`
`11553`	`11553`	`/*****************************************************************************`
`11554`	`11554`	`*`
`11555`	`11555`	`*QUERY:`
`11556`		`- *CLUSTER (options) <qualified_name> [ USING <index_name> ]`
	`11556`	`+ *CLUSTER (options)[<qualified_name> [ USING <index_name> ] ]`
`11557`	`11557`	`*CLUSTER [VERBOSE] [ <qualified_name> [ USING <index_name> ] ]`
`11558`	`11558`	`*CLUSTER [VERBOSE] <index_name> ON <qualified_name> (for pre-8.3)`
`11559`	`11559`	`*`
`@@ -11569,6 +11569,15 @@ ClusterStmt:`
`11569`	`11569`	`n->params =$3;`
`11570`	`11570`	`$$ = (Node *) n;`
`11571`	`11571`	`}`
	`11572`	`+\|CLUSTER'('utility_option_list')'`
	`11573`	`+{`
	`11574`	`+ClusterStmt *n = makeNode(ClusterStmt);`
	`11575`	`+`
	`11576`	`+n->relation =NULL;`
	`11577`	`+n->indexname =NULL;`
	`11578`	`+n->params =$3;`
	`11579`	`+$$ = (Node *) n;`
	`11580`	`+}`
`11572`	`11581`	`/* unparenthesized VERBOSE kept for pre-14 compatibility*/`
`11573`	`11582`	`\|CLUSTERopt_verbosequalified_namecluster_index_specification`
`11574`	`11583`	`{`
`@@ -11581,6 +11590,7 @@ ClusterStmt:`
`11581`	`11590`	`n->params = lappend(n->params, makeDefElem("verbose",NULL,@2));`
`11582`	`11591`	`$$ = (Node *) n;`
`11583`	`11592`	`}`
	`11593`	`+/* unparenthesized VERBOSE kept for pre-17 compatibility*/`
`11584`	`11594`	`\|CLUSTERopt_verbose`
`11585`	`11595`	`{`
`11586`	`11596`	`ClusterStmt *n = makeNode(ClusterStmt);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcdaedfc

File tree

2 files changed

2 files changed

`‎doc/src/sgml/ref/cluster.sgml`

`‎src/backend/parser/gram.y`

0 commit comments