Commitcd1e23e

committed

Fix ancient connection leak in dblink

When using unnamed connections with dblink, every time a newconnection is made, the old one is leaked. Fix that.This has been an issue probably since dblink was first committed.Someone complained almost ten years ago, but apparently I decidednot to pursue it at the time, and neither did anyone else, so itslipped between the cracks. Now that someone else has complained,fix in all supported branches.Discussion: (orig)https://postgr.es/m/flat/F680AB59-6D6F-4026-9599-1BE28880273D%40decibel.org#F680AB59-6D6F-4026-9599-1BE28880273D@decibel.orgDiscussion: (new)https://postgr.es/m/flat/0A3221C70F24FB45833433255569204D1F6ADF8C@G01JPEXMBYT05Reported by: Jim Nasby and Takayuki Tsunakawa

1 parentb58fd4a commitcd1e23eCopy full SHA for cd1e23e

File tree

-0

lines changed

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,11 @@ dblink_connect(PG_FUNCTION_ARGS)`
`304`	`304`	`createNewConnection(connname,rconn);`
`305`	`305`	`}`
`306`	`306`	`else`
	`307`	`+{`
	`308`	`+if (pconn->conn)`
	`309`	`+PQfinish(pconn->conn);`
`307`	`310`	`pconn->conn=conn;`
	`311`	`+}`
`308`	`312`
`309`	`313`	`PG_RETURN_TEXT_P(cstring_to_text("OK"));`
`310`	`314`	`}`

Comments

(0)