Commitcd1c8b9

committed

Avoid low-probability crash on out-of-memory.

check_restrict_nonsystem_relation_kind() correctly uses guc_malloc()in v16 and later. But in older branches it must use malloc()directly, and it forgot to check for failure return.Faulty backpatching of66e9444.Karina LitskevichDiscussion:https://postgr.es/m/CACiT8iZ=atkguKVbpN4HmJFMb4+T9yEowF5JuPZG8W+kkZ9L6w@mail.gmail.com

1 parent1168acb commitcd1c8b9Copy full SHA for cd1c8b9

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3489,6 +3489,11 @@ check_restrict_nonsystem_relation_kind(char newval, void extra, GucSource so`
`3489`	`3489`
`3490`	`3490`	`/* Save the flags in extra, for use by the assign function /`
`3491`	`3491`	`*extra=malloc(sizeof(int));`
	`3492`	`+if (*extra==NULL)`
	`3493`	`+ereport(ERROR,`
	`3494`	`+(errcode(ERRCODE_OUT_OF_MEMORY),`
	`3495`	`+errmsg("out of memory")));`
	`3496`	`+`
`3492`	`3497`	`((int)*extra)=flags;`
`3493`	`3498`
`3494`	`3499`	`return true;`

Comments

(0)