Commitcadd98c

committed

Fix overly generic name in with.sql test.

Avoid the name "test". In the 10 branch, this could clash withalter_table.sql, as seen in the build farm. That other instance wasalready renamed in later branches by commit2cf8c7a, but it's good tofuture-proof the name here too.Back-patch to 10.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/CA%2BhUKGJf4RAXUyAYVUcQawcptX%3DnhEco3SYpuPK5cCbA-F1eLA%40mail.gmail.com

1 parente4f7c51 commitcadd98cCopy full SHA for cadd98c

File tree

+13

-13

lines changed

+13

-13

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -2392,19 +2392,19 @@ with ordinality as (select 1 as x) select * from ordinality;`
`2392`	`2392`	`(1 row)`
`2393`	`2393`
`2394`	`2394`	`-- check sane response to attempt to modify CTE relation`
`2395`		`-WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`2396`		`-ERROR: relation "test" does not exist`
`2397`		`-LINE 1: WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`2398`		`- ^`
	`2395`	`+WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (1);`
	`2396`	`+ERROR: relation "with_test" does not exist`
	`2397`	`+LINE 1: WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (...`
	`2398`	`+^`
`2399`	`2399`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`2400`	`2400`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`2401`	`2401`	`-- statements)`
`2402`		`-create temp tabletest (i int);`
`2403`		`-withtest as (select 42) insert intotest select * fromtest;`
`2404`		`-select * fromtest;`
	`2402`	`+create temp tablewith_test (i int);`
	`2403`	`+withwith_test as (select 42) insert intowith_test select * fromwith_test;`
	`2404`	`+select * fromwith_test;`
`2405`	`2405`	`i`
`2406`	`2406`	`----`
`2407`	`2407`	`42`
`2408`	`2408`	`(1 row)`
`2409`	`2409`
`2410`		`-drop tabletest;`
	`2410`	`+drop tablewith_test;`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1120,12 +1120,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word`
`1120`	`1120`	`with ordinalityas (select1as x)select*from ordinality;`
`1121`	`1121`
`1122`	`1122`	`-- check sane response to attempt to modify CTE relation`
`1123`		`-WITHtestAS (SELECT42)INSERT INTOtestVALUES (1);`
	`1123`	`+WITHwith_testAS (SELECT42)INSERT INTOwith_testVALUES (1);`
`1124`	`1124`
`1125`	`1125`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`1126`	`1126`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`1127`	`1127`	`-- statements)`
`1128`		`-create temp tabletest (iint);`
`1129`		`-withtestas (select42)insert intotestselect*fromtest;`
`1130`		`-select*fromtest;`
`1131`		`-droptabletest;`
	`1128`	`+create temp tablewith_test (iint);`
	`1129`	`+withwith_testas (select42)insert intowith_testselect*fromwith_test;`
	`1130`	`+select*fromwith_test;`
	`1131`	`+droptablewith_test;`

Comments

(0)