NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitcad2207

committed

Fix bogus size calculation introduced by commitcc5f813.

The elements of RecordCacheArray are TupleDesc, not TupleDesc *.Those are actually the same size, so that this error is harmless,but it's still wrong --- and it might bite us someday, if TupleDescever became a struct, say.Per Coverity.

1 parent936df5b commitcad2207Copy full SHA for cad2207

File tree

1 file changed

-1

lines changed

src/backend/utils/cache
- typcache.c

1 file changed

-1

lines changed

`‎src/backend/utils/cache/typcache.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1386,7 +1386,7 @@ ensure_record_cache_typmod_slot_exists(int32 typmod)`
`1386`	`1386`	`RecordCacheArray= (TupleDesc*)repalloc(RecordCacheArray,`
`1387`	`1387`	`newlen*sizeof(TupleDesc));`
`1388`	`1388`	`memset(RecordCacheArray+RecordCacheArrayLen,0,`
`1389`		`- (newlen-RecordCacheArrayLen)sizeof(TupleDesc));`
	`1389`	`+ (newlen-RecordCacheArrayLen)*sizeof(TupleDesc));`
`1390`	`1390`	`RecordCacheArrayLen=newlen;`
`1391`	`1391`	`}`
`1392`	`1392`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcad2207

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/typcache.c`

0 commit comments