NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitca84dfa

committed

Prevent Valgrind Memcheck errors around px_acquire_system_randomness().

This function uses uninitialized stack and heap buffers as supplementaryentropy sources. Mark them so Memcheck will not complain. Back-patchto 9.4, where Valgrind Memcheck cooperation first appeared.Marko Tiikkaja

1 parent258e294 commitca84dfaCopy full SHA for ca84dfa

File tree

1 file changed

-1

lines changed

contrib/pgcrypto
- random.c

1 file changed

-1

lines changed

`‎contrib/pgcrypto/random.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@`
`32`	`32`	`#include"postgres.h"`
`33`	`33`
`34`	`34`	`#include"px.h"`
	`35`	`+#include"utils/memdebug.h"`
`35`	`36`
`36`	`37`	`/* how many bytes to ask from system random provider */`
`37`	`38`	`#defineRND_BYTES 32`
`@@ -195,16 +196,18 @@ try_unix_std(uint8 *dst)`
`195`	`196`	`memcpy(dst, (uint8*)&x,sizeof(x));`
`196`	`197`	`dst+=sizeof(x);`
`197`	`198`
`198`		`-/let's be desperate /`
	`199`	`+/hash of uninitialized stack and heap allocations /`
`199`	`200`	`res=px_find_digest("sha1",&md);`
`200`	`201`	`if (res >=0)`
`201`	`202`	`{`
`202`	`203`	`uint8*ptr;`
`203`	`204`	`uint8stack[8192];`
`204`	`205`	`intalloc=32*1024;`
`205`	`206`
	`207`	`+VALGRIND_MAKE_MEM_DEFINED(stack,sizeof(stack));`
`206`	`208`	`px_md_update(md,stack,sizeof(stack));`
`207`	`209`	`ptr=px_alloc(alloc);`
	`210`	`+VALGRIND_MAKE_MEM_DEFINED(ptr,alloc);`
`208`	`211`	`px_md_update(md,ptr,alloc);`
`209`	`212`	`px_free(ptr);`
`210`	`213`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitca84dfa

File tree

1 file changed

1 file changed

`‎contrib/pgcrypto/random.c`

0 commit comments