Commitc965c42

committed

Fix EXTRACT(ISOYEAR FROM timestamp) for years BC.

The test cases added by commit26ae3aa exposed an old oversight intimestamp[tz]_part: they didn't correct the result of date2isoyear()for BC years, so that we produced an off-by-one answer for such years.Fix that, and back-patch to all supported branches.Discussion:https://postgr.es/m/SG2PR06MB37762CAE45DB0F6CA7001EA9B6550@SG2PR06MB3776.apcprd06.prod.outlook.com

1 parentf3cf330 commitc965c42Copy full SHA for c965c42

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4125,6 +4125,7 @@ date2isoweek(int year, int mon, int mday)`
`4125`	`4125`	`/* date2isoyear()`
`4126`	`4126`	`*`
`4127`	`4127`	`*Returns ISO 8601 year number.`
	`4128`	`+ *Note: zero or negative results follow the year-zero-exists convention.`
`4128`	`4129`	`*/`
`4129`	`4130`	`int`
`4130`	`4131`	`date2isoyear(intyear,intmon,intmday)`
`@@ -4399,6 +4400,9 @@ timestamp_part(PG_FUNCTION_ARGS)`
`4399`	`4400`
`4400`	`4401`	`caseDTK_ISOYEAR:`
`4401`	`4402`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4403`	`+/* Adjust BC years */`
	`4404`	`+if (result <=0)`
	`4405`	`+result-=1;`
`4402`	`4406`	`break;`
`4403`	`4407`
`4404`	`4408`	`caseDTK_DOW:`
`@@ -4595,6 +4599,9 @@ timestamptz_part(PG_FUNCTION_ARGS)`
`4595`	`4599`
`4596`	`4600`	`caseDTK_ISOYEAR:`
`4597`	`4601`	`result=date2isoyear(tm->tm_year,tm->tm_mon,tm->tm_mday);`
	`4602`	`+/* Adjust BC years */`
	`4603`	`+if (result <=0)`
	`4604`	`+result-=1;`
`4598`	`4605`	`break;`
`4599`	`4606`
`4600`	`4607`	`caseDTK_DOW:`

Lines changed: 1 addition & 1 deletion

Lines changed: 1 addition & 1 deletion

Comments

(0)